Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add CSS styleguide and rename development files #332

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

seanes
Copy link
Collaborator

@seanes seanes commented Mar 20, 2024

Forslag til en ukontroversiell og enkel styleguide. Kan med fordel vokse, men som jeg skriver, er det ikke yet another strict and idiosyncratic book of css full of do's and dont's..

Hva er endret?

Dokumentasjon / Storybook / testdekning

  • Dokumentasjon er oppdatert eller ikke relevant / nødvendig.
  • Ny komponent har en eller flere stories i Storybook, eller så er ikke dette relevant.
  • Det er blitt lagt til nye tester / eksiterende tester er blitt utvidet, eller tester er ikke relevant.

Skjermbilder eller GIFs (valgfritt)

@seanes seanes requested a review from a team as a code owner March 20, 2024 11:49
Copy link
Contributor

@TheKnarf TheKnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion above ^

Copy link
Contributor

@TheKnarf TheKnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as first iteration. Maybe @alexdigdir also want to look over it before we merge it.

@seanes seanes merged commit 79291de into main Mar 20, 2024
9 checks passed
@seanes seanes deleted the doc/styleguide branch March 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants