Feature/filter component #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanes
force-pushed
the
feature/filter_component
branch
2 times, most recently
from
056fbf4
to
20e54bb
Compare
seanes
force-pushed
the
feature/filter_component
branch
from
50483b9
to
1e5913a
Compare
alexdigdir
approved these changes
Mar 18, 2024
| align-items: center; | ||
| justify-content: center; | ||
| background-color: rgb(243, 244, 246); | ||
| color: rgba(0,0,0); |
There was a problem hiding this comment.
flisespikk, men hvorfor ikke bare skrive "black" og spare å kjøre en funksjon? :)
There was a problem hiding this comment.
det skal byttes uansett, koster ingenting
TheKnarf
reviewed
Mar 18, 2024
| <Button size="small" onClick={onBtnClick} disabled={disabled} variant="secondary" color="first"> | ||
| <PlusIcon /> {t('filter_bar.add_filter')} | ||
| </Button> | ||
| {isOpen && ( |
There was a problem hiding this comment.
Potentially refactor this into a <ButtonWithDropdown />-component? To extract the button, isOpen and dropdown functionality.
There was a problem hiding this comment.
Vi må se hvor gjenbrukbart det kan bli på sikt, og behovene. Ser ingen verdi i å skille ut dette som egen komponent foreløpig.
TheKnarf
reviewed
Mar 18, 2024
| * /> | ||
| * ``` | ||
| */ | ||
| export const FilterBar = ({ onFilterChange, fields, initialFilters = [] }: FilterBarProps) => { |
There was a problem hiding this comment.
Maybe we could write a unit test for this component?
TheKnarf
approved these changes
Mar 18, 2024
|
Venter med enhetstester til denne er blitt litt mer moden og vi er blitt enige om på hvilket nivå vi skal legge oss. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamisk filterkomponent (
Filterbar) ansvarlig for visning og kontroll av filtre, som generer et sett med filtre for filtrering av data.Hva er endret?
Dette er første iterasjon.
Dokumentasjon / Storybook / testdekning
Eksempler i Storybook.
storiesiStorybook, eller så er ikke dette relevant.Skjermbilder eller GIFs (valgfritt)