Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser history should not include double entries #1347

Closed
Tracked by #1317
seanes opened this issue Nov 7, 2024 · 1 comment · Fixed by #1351
Closed
Tracked by #1317

fix: browser history should not include double entries #1347

seanes opened this issue Nov 7, 2024 · 1 comment · Fixed by #1351
Assignees
Labels
dev developer task

Comments

@seanes
Copy link
Collaborator

seanes commented Nov 7, 2024

When performing a search, the url query parameter search gets added or modified with search query, e.g. ?search=hei. Clicking history back / back button, should not render url with search param included, and input in search should be removed.

@LeifHelstad
Copy link
Contributor

LeifHelstad commented Nov 11, 2024

Det er noe caching i nettleseren som skaper litt usikkerhet i testen.
Noen ganger kommer søkekriteriet dobbelt i nettleseren. I en helt frisk sesjon observerer jeg at hvis jeg gjør et søk så vil pil tilbake gi en URL uten search.
(Hvis man underveis angir et tomt søk altså at search= blank så er dette et gyldig søk og huskes,)

Å åpne søk uten å angi noe for så å lukke søk med X huskes i historikk som en egen sidevisning der søk ikke er angitt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev developer task
Projects
Status: Done
3 participants