Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: history back should read query correct selected party from state #1346

Closed
Tracked by #1317
seanes opened this issue Nov 7, 2024 · 2 comments · Fixed by #1350
Closed
Tracked by #1317

fix: history back should read query correct selected party from state #1346

seanes opened this issue Nov 7, 2024 · 2 comments · Fixed by #1350
Assignees
Labels
dev developer task

Comments

@seanes
Copy link
Collaborator

seanes commented Nov 7, 2024

Selecting a party or all organization adds or modifies query params depending on option (party if organization or allParties if all organizations). Triggering history back, should respect previous query search param, i.e select correct party option depending on query param and fetch correct data (saved searches and dialogs) for this party/parties.

@seanes seanes changed the title fix: history back should update state from url fix: history back should read query correct selected party from state Nov 7, 2024
@seanes seanes added the dev developer task label Nov 7, 2024
@seanes seanes moved this from New issues to Doing in Dialogporten / Arbeidsflate Nov 7, 2024
@github-project-automation github-project-automation bot moved this from Code Review og PR to Done in Dialogporten / Arbeidsflate Nov 7, 2024
@mbacherycz mbacherycz moved this from Done to Testing / Design QA in Dialogporten / Arbeidsflate Nov 7, 2024
@LeifHelstad LeifHelstad added this to the Navigasjon i Arbeidsflate milestone Nov 8, 2024
@LeifHelstad
Copy link
Contributor

Denne fungerer ikke helt. Og testingen kompliseres av at #1347 ikke er levert. Jeg setter denne til Failed inntil videre

@LeifHelstad
Copy link
Contributor

Denne fungerer nå. Det ble en enkel test med problemet i #1355 der man ved å åpne en melding mister party og havner i feil kontekst.
Denne #1346 retter problemet slik at en nettleser "history-back" sender bruker tilbake til forrige side der party fortsatt huskes rett.
Det var nødvendig å rette #1347 før #1346 kunne testes, hvis ikke var det for mye rart i history.
En observasjon fra #1347 var at nettleserloggen måtte slettes før testing kunne fortsette, hvis ikke ble den rare historikken husket og påvirket resultatet.

@LeifHelstad LeifHelstad moved this from Testing / Design QA to Done in Dialogporten / Arbeidsflate Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev developer task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants