Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Field): cleanup stories and position prop #2931

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(Field): cleanup stories and position prop #2931

wants to merge 1 commit into from

Conversation

eirikbacker
Copy link
Contributor

  • Docs: clean up stories
  • Fix: use position prop in data-position

@eirikbacker eirikbacker self-assigned this Dec 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 20. Dec 2024 - 14:07

@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.24% 3203 / 5798
🔵 Statements 55.24% 3203 / 5798
🔵 Functions 86.6% 181 / 209
🔵 Branches 76.96% 518 / 673
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/Field/Field.tsx 100% 100% 100% 100%
Generated in workflow #1385 for commit 5ebe0b5 by the Vitest Coverage Report Action

mimarz
mimarz requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changeset for fix of position. Changeset bot, did you go on christmas holdiday? 🎅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz requested changes

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes is a code owner

@unekinn unekinn Awaiting requested review from unekinn unekinn is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@eirikbacker eirikbacker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eirikbacker @mimarz