feat(Tooltip): use popover API #2916
Conversation
🦋 Changeset detectedLatest commit: b115b69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Preview deployments for this pull request: Storybook - |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
|
Tooltip placement appears wrong place on in this story in Safari :/ |
Unfortunatley I can't debug safari-only issues |
| return () => { | ||
| window.removeEventListener('keydown', handleKeyDown); | ||
| }; | ||
| }, []); |
There was a problem hiding this comment.
Vi trenger kanskje ikke ESC når den uansett forsvinner på blur og mouseleave?
There was a problem hiding this comment.
Eg lurte på det også, men eg tenker kanskje det er greit å følge w3c sitt mønster, sølv om det enda er WIP
resolves #2897
It works like the old tooltip, but if the trigger is an element that can trigger a popover, a click will close it.
This is because we don't prevent the default event, to make sure we don't stop any events from propogating.