Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add article about data-color #2830

Open
wants to merge 19 commits into
base: next
Choose a base branch
from
Open

docs: add article about data-color #2830

wants to merge 19 commits into from

Conversation

Barsnes
Copy link
Member

@Barsnes Barsnes commented Nov 25, 2024 •
edited by mimarz
Loading

#2928

Also fixes some color issues on the storefront.

This is written as short as possible, and only about the usage of these. What they do (change variables) is not documented here, as this should live on another documentation page.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae4f2af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Preview deployments for this pull request:

Storefront - 20. Dec 2024 - 12:30

Theme - 28. Nov 2024 - 09:17

@Barsnes Barsnes marked this pull request as ready for review November 26, 2024 07:52
@Barsnes Barsnes marked this pull request as draft November 26, 2024 09:51
@Barsnes Barsnes marked this pull request as ready for review November 27, 2024 07:50
@Barsnes
Copy link
Member Author

Barsnes commented Nov 27, 2024

Setting to draft as we will change this a bit, and it will affect how we word ourselves in this article

@Barsnes Barsnes marked this pull request as draft November 27, 2024 14:49
@Barsnes Barsnes mentioned this pull request Nov 28, 2024
Merged
Barsnes added a commit that referenced this pull request Nov 28, 2024
@Barsnes
chore: storefront fixes (#2844)
e9aaa40 
This PR ports over changes and fixes from #2830
resolves #2840
resolves #2816

New codeblock styling is approved by @Thunear
@Barsnes Barsnes marked this pull request as ready for review December 10, 2024 07:19
mimarz
mimarz reviewed Dec 11, 2024
View reviewed changes
apps/storefront/app/grunnleggende/for-utviklere/fargar/page.mdx

## `data-color`

Dette data-attributtet blir brukt for å endre fargen til ein komponent. Du kan bruke alle fargane som finst i temaet ditt.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevn at det er fargene du har definert i temabygger og link til den?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eg tenker nei, sia artikkelen tar forbehold om at du har brukt den allerede, og er linka i toppen

@Barsnes Barsnes changed the title docs: start article about data-color docs: add article about data-color Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz mimarz left review comments

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker is a code owner

@unekinn unekinn Awaiting requested review from unekinn unekinn is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Team Design System
Status: 👀 Ready for review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Barsnes @mimarz