Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css,react): smoother spinner animation using opacity #2791

Draft
wants to merge 14 commits into
base: next
Choose a base branch
from
Draft

fix(css,react): smoother spinner animation using opacity #2791

wants to merge 14 commits into from

Conversation

unekinn
Copy link
Contributor

@unekinn unekinn commented Nov 15, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Preview deployments for this pull request:

Storybook - 18. Nov 2024 - 11:33

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 55.06% 3187 / 5788
🔵 Statements 55.06% 3187 / 5788
🔵 Functions 87.14% 183 / 210
🔵 Branches 76.84% 521 / 678
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/react/src/components/loaders/Spinner/Spinner.tsx 100% 100% 100% 100%
Generated in workflow #957 for commit a158a39 by the Vitest Coverage Report Action

@unekinn unekinn force-pushed the fix/smoother-spinner branch from 8226377 to 545e6f4 Compare November 15, 2024 15:24
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a158a39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

unekinn added 13 commits November 18, 2024 11:14
@unekinn
fix(storybook): incorrect css variables shown in List docs
8eb0c56
@unekinn
fix(storybook): list all --dsc- properties in CssVariables regardless…
52cbe7e 
… of location in css file
@unekinn
refactor(css,react): rewrite existing data-color components to use ge…
67ca1e7 
…neric color vars
@unekinn
feat(css): change all components from color-accent to generic, inheri…
fe45e17 
…ted color
@unekinn
feat(react): remove default accent color, let it be inherited through…
e7867a4 
… data-color instead
@unekinn
fix(test): remove check for data-color="accent" in Avatar test
55520e6
@unekinn
fix(css,react): spinner with multiple colors
102e1b2
@unekinn
fix(cli): require an "accent" color
dd9d194
@unekinn
feat(react): add very permissible type to data-color
195b776
@unekinn
feat(react): color -> data-color + document data-{color,size} for all…
c6cc412 
… components
@unekinn
fix(css,react): avatar, button and link default to accent color
278f2bb
@unekinn
fix: Merge -> MergeRight
67db79b
@unekinn
fix: remove "import ... from 'packages/react/..."
58ecb78
@unekinn unekinn force-pushed the feat/use-data-colors-on-all-components branch from 5a0f838 to 58ecb78 Compare November 18, 2024 10:21
@unekinn unekinn force-pushed the fix/smoother-spinner branch from 545e6f4 to a158a39 Compare November 18, 2024 10:31
@unekinn unekinn mentioned this pull request Nov 18, 2024
Merged
@unekinn unekinn force-pushed the feat/use-data-colors-on-all-components branch 3 times, most recently from 9585205 to 092d302 Compare November 18, 2024 18:16
Base automatically changed from feat/use-data-colors-on-all-components to next November 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimarz mimarz Awaiting requested review from mimarz mimarz will be requested when the pull request is marked ready for review mimarz is a code owner

@Barsnes Barsnes Awaiting requested review from Barsnes Barsnes will be requested when the pull request is marked ready for review Barsnes is a code owner

@eirikbacker eirikbacker Awaiting requested review from eirikbacker eirikbacker will be requested when the pull request is marked ready for review eirikbacker is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@unekinn