Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line number for files with no newline #8558

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

kroening
Copy link
Member

@kroening kroening commented Jan 6, 2025

The parser sets the line number used for error messages once reaching a newline. This fixes the logic for the case that the input file does not have a newline.

This is only visible on .i files, as the preprocessor adds a newline when there isn't one on .c files.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The parser sets the line number used for error messages once reaching a
newline.  This fixes the logic for the case that the input file does not
have a newline.

This is only visible on .i files, as the preprocessor adds a newline when
there isn't one on .c files.
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (e5e5c65) to head (6ee9f5b).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8558      +/-   ##
===========================================
+ Coverage    79.14%   79.60%   +0.45%     
===========================================
  Files         1733     1733              
  Lines       198512   197381    -1131     
  Branches     18173    18173              
===========================================
+ Hits        157119   157122       +3     
+ Misses       41393    40259    -1134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant