📝 Update docstrings wallet/dids #817

cl0ete · 2024-05-24T09:41:27Z

Update wallet/did docstrings

Create DID endpoint request model now extends AcaPy model, to flatten options field. This brings key_type and did fields up.

⚠️ Deprecates the options field in the DIDCreate request body, and moves the nested key_type and did fields up one level.

github-actions · 2024-05-28T07:22:27Z

Coverage Report

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	204	106	48%	107–189, 197–216, 261–350, 391–392, 450–466, 481–487, 508–517, 540–541, 558–560, 616–677, 721–722
issuer.py	173	38	78%	95–97, 126, 189–191, 199, 216, 272, 285, 336, 409, 463, 585–616, 659–669, 715–726
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	32–41, 61–71
oob.py	46	28	39%	27–68, 79–92, 116–127
verifier.py	147	33	78%	64–66, 71, 109–111, 116, 158, 166–168, 173, 207–212, 218–220, 270–272, 278, 311–313, 318, 348–350, 384–386
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
dids.py	76	22	71%	46–55, 81–82, 112–113, 140–147, 170–178
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	132	12	91%	314–318, 346, 356–361, 394–398, 426–431
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	22	78%	60–63, 87–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	46	12	74%	142–215
test_verifier.py	231	12	95%	683–756
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	120	37	69%	176, 271–352, 365–437
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/services
test_revocation_registry.py	135	2	99%	73, 104
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	86	27	69%	114–139, 148–165, 182–191, 246–263
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	45	4	91%	19, 74–77, 100
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
credentials.py	13	4	69%	6, 11, 18, 21
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13294	1039	92%

Tests	Skipped	Failures	Errors	Time
892	10 💤	0 ❌	0 🔥	9m 48s ⏱️

sonarqubecloud · 2024-06-03T13:41:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions · 2024-06-03T13:59:32Z

Coverage Report

File	Stmts	Miss	Cover	Missing
app/routes
definitions.py	204	106	48%	107–189, 197–216, 261–350, 391–392, 450–466, 481–487, 508–517, 540–541, 558–560, 616–677, 721–722
issuer.py	173	38	78%	95–97, 126, 189–191, 199, 216, 272, 285, 336, 409, 463, 585–616, 659–669, 715–726
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	32–41, 61–71
oob.py	46	28	39%	27–68, 79–92, 116–127
verifier.py	147	33	78%	64–66, 71, 109–111, 116, 158, 166–168, 173, 207–212, 218–220, 270–272, 278, 311–313, 318, 348–350, 384–386
webhooks.py	16	4	75%	32–36, 57–61
websocket_endpoint.py	23	8	65%	24–25, 37–42, 54–57, 70–76
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
dids.py	76	22	71%	46–55, 81–82, 112–113, 140–147, 170–178
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	132	12	91%	314–318, 346, 356–361, 394–398, 426–431
webhooks.py	27	18	33%	17–25, 29–39
websocket.py	51	41	20%	19–22, 29–36, 47–91
app/services/event_handling
websocket_manager.py	73	26	64%	64–68, 87–90, 97–108, 115–125, 139
app/services/issuer
acapy_issuer_v1.py	87	14	84%	36, 76–110, 197–198
acapy_issuer_v2.py	101	22	78%	60–63, 87–127, 173, 219–220, 247
app/services/onboarding
tenants.py	59	45	24%	30–98, 108–138
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	86	3	97%	100–102
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	49	4	92%	56–61, 91–96
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_jsonld.py	59	16	73%	134–169
test_tenants.py	349	15	96%	186, 230–231, 263, 716, 754–755, 764–765, 774–775, 787–788, 797–798
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	69	10	86%	93–108
app/tests/e2e/issuer
test_save_exchange_record.py	72	1	99%	177
app/tests/e2e/verifier
test_proof_revoked_credential.py	46	12	74%	142–215
test_verifier.py	231	12	95%	683–756
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	120	37	69%	176, 271–352, 365–437
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/services
test_revocation_registry.py	135	2	99%	73, 104
app/tests/services/issuer
test_issuer.py	160	2	99%	335–339
app/tests/util
connections.py	86	27	69%	114–139, 148–165, 182–191, 246–263
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	41	8	80%	50–55, 79–84
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	45	4	91%	19, 74–77, 100
app/util
acapy_issuer_utils.py	18	1	94%	22
acapy_verifier_utils.py	137	5	96%	108–111, 191–195, 272
credentials.py	13	4	69%	6, 11, 18, 21
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
endorser/services
endorsement_processor.py	137	6	96%	90, 152–162
webhooks/models
conversions.py	63	6	90%	70, 83, 91, 112, 149, 168
webhooks/services
acapy_events_processor.py	186	22	88%	98, 161–171, 219–223, 251, 279–280, 308–312, 325–329, 354–367
billing_manager.py	175	4	98%	91, 98–99, 132
sse_manager.py	235	36	85%	153, 155–168, 206–216, 245–246, 259–273, 328–332, 338–341, 343–346, 371–372, 415–417, 451, 462–463
webhooks_redis_service.py	140	19	86%	70, 237–238, 354, 378–398, 411–422
webhooks/tests/services
test_sse_manager.py	180	3	98%	211–212, 218
webhooks/web/routers
sse.py	102	3	97%	168–171
TOTAL	13294	1039	92%

Tests	Skipped	Failures	Errors	Time
892	10 💤	0 ❌	0 🔥	9m 11s ⏱️

app/routes/wallet/dids.py

app/models/wallet.py

github-actions · 2024-10-28T11:44:40Z

K8s Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	117–118
app/models
wallet.py	26	5	81%	50–60
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	12	80%	110–111, 124–140, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	35	79%	118–160, 201–205, 360–364, 403–408, 441–445, 473–478, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 227–228, 255
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	88	3	97%	103–105
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_connections.py	149	2	99%	281–282
test_did_exchange.py	73	21	71%	124–187
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	24	1	96%	101
test_tenants.py	421	15	96%	203, 247–248, 287, 789, 833–834, 843–844, 853–854, 866–867, 876–877
test_wallet_credentials.py	30	1	97%	55
test_wallet_dids.py	70	10	86%	101–116
app/tests/e2e/issuer
test_get_records_paginated.py	63	2	97%	65–66
test_save_exchange_record.py	72	1	99%	166
app/tests/e2e/verifier
test_get_records_paginated.py	62	2	97%	59–60
test_many_revocations.py	61	40	34%	31–107, 117–128, 139–214
test_proof_revoked_credential.py	44	12	73%	127–199
test_verifier.py	224	12	95%	661–731
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	120	37	69%	173, 268–348, 361–432
definitions.py	66	26	61%	29–50, 64–65, 94–124, 143–144
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_connections.py	43	8	81%	80–91, 130–141
member_wallets.py	61	15	75%	29–34, 49–54, 69–74, 89–94, 111–118
app/tests/routes/issuer
test_create_offer.py	39	1	97%	145
test_send_credential.py	36	1	97%	125
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	141	2	99%	74, 105
app/tests/services/issuer
test_issuer.py	123	2	98%	281–285
app/tests/util
connections.py	87	29	67%	104–129, 138–155, 172–181, 236–256
ledger.py	50	10	80%	35, 43, 55, 63–67, 77, 83
regression_testing.py	35	17	51%	33, 41–68, 74–81
sse_listener.py	28	4	86%	51–56
trust_registry.py	29	3	90%	24, 27–28
webhooks.py	53	15	72%	19, 65–81, 88–90, 95, 119
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	8	56%	17–33
credentials.py	14	2	86%	13, 18
retry_method.py	36	15	58%	20–35, 76–77, 91–103
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	2	86%	31–32
endorser
main.py	50	1	98%	56
endorser/services
endorsement_processor.py	108	10	91%	115–116, 202–213
endorser/tests
test_util_endorsement.py	144	5	97%	286, 291, 350–352
endorser/util
endorsement.py	68	7	90%	134–146
trustregistry
main.py	82	4	95%	46–48, 110
trustregistry/tests
test_main.py	137	1	99%	90
waypoint
main.py	48	1	98%	64
waypoint/tests/routers
test_waypoint_sse.py	83	5	94%	61–62, 120, 138, 174
waypoint/tests/services
test_nats_service.py	119	3	97%	46, 140, 162
TOTAL	12499	818	93%

Tests	Skipped	Failures	Errors	Time
835	6 💤	0 ❌	0 🔥	2m 39s ⏱️

github-actions · 2024-10-28T11:44:41Z

K8s Regression Test Coverage

File	Stmts	Miss	Cover	Missing
app
main.py	78	2	97%	117–118
app/models
wallet.py	26	5	81%	50–60
app/routes
jsonld.py	60	47	22%	23–93, 104–137
messaging.py	24	11	54%	43–52, 85–95
oob.py	46	28	39%	58–99, 131–144, 170–181
trust_registry.py	62	2	97%	52–53
verifier.py	139	33	76%	88–90, 95, 152–154, 159, 231, 239–241, 246, 288–293, 299–301, 362–364, 369, 406–408, 413, 449–451, 505–507
app/routes/wallet
credentials.py	77	52	32%	32–45, 54–66, 75–86, 95–109, 120–136, 148–162, 171–183, 192–203
jws.py	42	27	36%	35–60, 76–99
sd_jws.py	42	27	36%	36–61, 78–101
app/services
acapy_ledger.py	61	19	69%	43–49, 79, 110–111, 124–140, 146–149, 196–197
acapy_wallet.py	40	4	90%	60–61, 98–99
revocation_registry.py	166	46	72%	118–160, 201–205, 360–364, 403–408, 441–445, 463–478, 484–493, 527–528
app/services/issuer
acapy_issuer_v2.py	101	12	88%	63, 97–106, 110, 126–127, 173, 227–228, 255
app/services/onboarding
tenants.py	63	49	22%	30–103, 113–143
verifier.py	37	3	92%	67, 83–87
app/services/onboarding/util
register_issuer_did.py	88	3	97%	103–105
set_endorser_metadata.py	72	40	44%	28–30, 50–52, 76–78, 109–128, 140–151, 163–176, 189–203
app/services/trust_registry
actors.py	107	9	92%	95–100, 110, 209–210, 212–217, 282–285
schemas.py	54	9	83%	57–63, 89–99
app/services/trust_registry/util
actor.py	31	2	94%	26–27
issuer.py	23	4	83%	39–40, 48–49
app/tests/e2e
conftest.py	23	5	78%	46–54
test_connections.py	149	2	99%	281–282
test_definitions.py	79	51	35%	33–56, 68–80, 92–106, 118–146, 164–209
test_did_exchange.py	73	21	71%	124–187
test_jsonld.py	59	16	73%	134–169
test_proof_request_models.py	24	1	96%	101
test_revocation.py	111	73	34%	27–77, 90–107, 118–144, 156–181, 193–207, 219–256, 267–293, 305–335, 346–349
test_tenants.py	421	364	14%	29–73, 84–117, 128–172, 185–254, 265–316, 329–459, 468–520, 529–565, 574–623, 632–681, 692–734, 746–795, 806–877, 886–993
test_wallet_dids.py	70	15	79%	101–116, 128–139
app/tests/e2e/issuer
test_get_records_paginated.py	63	52	17%	25–161
test_save_exchange_record.py	72	1	99%	166
app/tests/e2e/verifier
test_get_credentials_by_proof_id.py	25	12	52%	27–81
test_get_records_paginated.py	62	49	21%	27–155
test_many_revocations.py	61	40	34%	31–107, 117–128, 139–214
test_proof_revoked_credential.py	44	11	75%	37–113
test_verifier_oob.py	68	22	68%	134–237
app/tests/exception_handling
test_handle_model_with_validation.py	23	1	96%	22
app/tests/fixtures
credentials.py	120	56	53%	130–204, 213–221, 231–253, 287–346, 381–430
definitions.py	66	10	85%	41–48, 57–63, 114–121, 134–139
member_acapy_clients.py	36	4	89%	47–50, 73–74
member_async_clients.py	50	2	96%	32–33
member_connections.py	43	4	91%	73, 91, 123, 141
member_wallets.py	61	15	75%	23–27, 43–47, 63–67, 83–87, 103–109
app/tests/routes/issuer
test_create_offer.py	39	1	97%	145
test_send_credential.py	36	1	97%	125
app/tests/routes/wallet/dids
test_get_public_did.py	29	1	97%	40
app/tests/services
test_revocation_registry.py	141	2	99%	74, 105
app/tests/services/issuer
test_issuer.py	123	2	98%	281–285
app/tests/util
connections.py	87	19	78%	154–155, 169, 181, 191–223, 251–256
ledger.py	50	26	48%	34–59, 63–67, 73–86
regression_testing.py	35	9	74%	33, 60–68, 74–81
sse_listener.py	28	4	86%	51–56
tenants.py	24	12	50%	10, 16–17, 21–26, 30–35, 39–44, 48–53, 57
trust_registry.py	29	7	76%	20–28
webhooks.py	53	15	72%	19, 65–81, 88–90, 95, 119
app/util
acapy_verifier_utils.py	123	5	96%	81–84, 164–168, 245
assert_public_did.py	18	12	33%	14–34
check_endorser_connection.py	10	4	60%	14–24
credentials.py	14	2	86%	13, 18
retry_method.py	36	30	17%	15–36, 68–114
string.py	15	4	73%	15–16, 20, 24
tenants.py	45	17	62%	24–29, 44–45, 52–59, 90–91, 97, 124
transaction_acked.py	14	7	50%	18–36
endorser
main.py	50	1	98%	56
endorser/services
endorsement_processor.py	108	10	91%	115–116, 202–213
endorser/tests
test_util_endorsement.py	144	5	97%	286, 291, 350–352
endorser/util
endorsement.py	68	7	90%	134–146
trustregistry
main.py	82	4	95%	46–48, 110
trustregistry/tests
test_main.py	137	1	99%	90
TOTAL	12058	1469	88%

Tests	Skipped	Failures	Errors	Time
835	40 💤	0 ❌	0 🔥	3m 37s ⏱️

… endpoint docstrings. Handle deprecated `options` field in different way. Only overwrites key_type and did if options are indeed passed.

sonarqubecloud · 2024-11-20T19:09:24Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cl0ete self-assigned this May 24, 2024

cl0ete added the documentation Improvements or additions to documentation label May 24, 2024

cl0ete changed the title ~~WIP: Update docstrings~~ WIP: Update docstrings wallet/dids May 24, 2024

cl0ete changed the title ~~WIP: Update docstrings wallet/dids~~ Update docstrings wallet/dids May 28, 2024

cl0ete marked this pull request as ready for review May 28, 2024 07:04

cl0ete temporarily deployed to dev May 28, 2024 07:05 — with GitHub Actions Inactive

cl0ete temporarily deployed to dev June 3, 2024 13:42 — with GitHub Actions Inactive

cl0ete requested a review from ff137 June 11, 2024 08:52

cl0ete marked this pull request as draft June 18, 2024 13:27

ff137 changed the title ~~Update docstrings wallet/dids~~ 📝 Update docstrings wallet/dids Jul 24, 2024

ff137 requested changes Oct 23, 2024

View reviewed changes

cl0ete force-pushed the swagger-update-wallet-dids branch 3 times, most recently from a7757dc to c0f2cde Compare October 28, 2024 08:20

github-advanced-security bot found potential problems Oct 28, 2024

View reviewed changes

app/models/wallet.py Fixed Show fixed Hide fixed

app/models/wallet.py Fixed Show fixed Hide fixed

app/models/wallet.py Fixed Show fixed Hide fixed

cl0ete marked this pull request as ready for review October 28, 2024 11:32

cl0ete requested a review from ff137 October 28, 2024 11:32

cl0ete temporarily deployed to dev October 28, 2024 11:34 — with GitHub Actions Inactive

cl0ete temporarily deployed to dev October 28, 2024 11:38 — with GitHub Actions Inactive

cl0ete force-pushed the swagger-update-wallet-dids branch 2 times, most recently from 3545772 to da2107d Compare November 7, 2024 07:41

cl0ete temporarily deployed to dev November 7, 2024 07:52 — with GitHub Actions Inactive

cl0ete had a problem deploying to dev November 7, 2024 07:55 — with GitHub Actions Failure

cl0ete temporarily deployed to dev November 7, 2024 07:55 — with GitHub Actions Inactive

cl0ete added 9 commits November 19, 2024 15:35

options takes priority

bff4a73

update docstrings

0c1f9fd

if not

593a6cd

add some types

5afb060

pass down acapy model

815db73

update test with new model

7a35fa3

black .

4a2b757

edits

4d625e8

tweak validator

5422d36

cl0ete force-pushed the swagger-update-wallet-dids branch from 4d69083 to 5422d36 Compare November 19, 2024 13:35

cl0ete temporarily deployed to dev November 19, 2024 13:48 — with GitHub Actions Inactive

cl0ete had a problem deploying to dev November 19, 2024 13:52 — with GitHub Actions Failure

ff137 added 5 commits November 20, 2024 20:49

🎨 Update DIDCreate model, add to_acapy_options, and update create_did…

876e2be

… endpoint docstrings. Handle deprecated `options` field in different way. Only overwrites key_type and did if options are indeed passed.

🎨 Update docstrings

774522d

🎨 Add one more example

190d6bf

✅ Fix new expected assertion

e5fb1a3

Merge branch 'master' into swagger-update-wallet-dids

71a9d16

ff137 temporarily deployed to dev November 20, 2024 19:01 — with GitHub Actions Inactive

🎨 Fix model description and type

de1e30c

ff137 had a problem deploying to dev November 20, 2024 19:04 — with GitHub Actions Failure

ff137 temporarily deployed to dev November 20, 2024 19:04 — with GitHub Actions Inactive

ff137 approved these changes Nov 20, 2024

View reviewed changes

ff137 enabled auto-merge (squash) November 20, 2024 19:09

ff137 temporarily deployed to dev November 20, 2024 19:10 — with GitHub Actions Inactive

ff137 had a problem deploying to dev November 20, 2024 19:15 — with GitHub Actions Failure

ff137 temporarily deployed to dev November 20, 2024 19:15 — with GitHub Actions Inactive

ff137 merged commit 8077903 into master Nov 20, 2024
47 of 48 checks passed

ff137 deleted the swagger-update-wallet-dids branch November 20, 2024 19:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

📝 Update docstrings wallet/dids #817

📝 Update docstrings wallet/dids #817

cl0ete commented May 24, 2024 •

edited by ff137

Loading

github-actions bot commented May 28, 2024

sonarqubecloud bot commented Jun 3, 2024

github-actions bot commented Jun 3, 2024

github-actions bot commented Oct 28, 2024

github-actions bot commented Oct 28, 2024

sonarqubecloud bot commented Nov 20, 2024

📝 Update docstrings wallet/dids #817

📝 Update docstrings wallet/dids #817

Conversation

cl0ete commented May 24, 2024 • edited by ff137 Loading

github-actions bot commented May 28, 2024

sonarqubecloud bot commented Jun 3, 2024

Quality Gate passed

github-actions bot commented Jun 3, 2024

github-actions bot commented Oct 28, 2024

github-actions bot commented Oct 28, 2024

sonarqubecloud bot commented Nov 20, 2024

Quality Gate passed

cl0ete commented May 24, 2024 •

edited by ff137

Loading