Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Resolve pylint warnings #1193

Merged
merged 1 commit into from
Nov 20, 2024
Merged

🎨 Resolve pylint warnings #1193

merged 1 commit into from
Nov 20, 2024

Conversation

ff137
Copy link
Collaborator

@ff137 ff137 commented Nov 20, 2024 •
edited
Loading

Resolves:

  • using list as default arg in RichAsyncClient
  • ignores "too many arguments" / etc warnings for methods that need it
  • fix unused argument in test fixture
  • ignore too general exception for tests
  • add "raise exception from" in schemas service

The only remaining warnings are todo's (excluding some warnings in tests)

@ff137 ff137 enabled auto-merge (squash) November 20, 2024 18:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ff137 ff137 merged commit 72b35e1 into master Nov 20, 2024
47 of 48 checks passed
@ff137 ff137 deleted the fix-pylint-warnings branch November 20, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ff137