-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Nats reconnect logic #1161
Merged
Merged
🐛 Nats reconnect logic #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl0ete
force-pushed
the
nats-reconnect-logic
branch
from
November 5, 2024 10:56
a9ef443
to
a6f0aad
Compare
cl0ete
force-pushed
the
nats-reconnect-logic
branch
from
November 5, 2024 14:23
39c6fb6
to
e73de23
Compare
cl0ete
force-pushed
the
nats-reconnect-logic
branch
from
November 6, 2024 13:03
6cffdd3
to
42e7e02
Compare
cl0ete
force-pushed
the
nats-reconnect-logic
branch
from
November 7, 2024 11:02
58f5384
to
d5f680b
Compare
ff137
reviewed
Nov 7, 2024
Quality Gate passedIssues Measures |
K8s Regression Test Coverage
|
ff137
reviewed
Nov 8, 2024
dockerfiles/agents/Dockerfile.agent
Outdated
@@ -7,7 +7,7 @@ ARG PROTOBUF_VERSION=5.28.1 | |||
RUN pip install --no-cache-dir protobuf==${PROTOBUF_VERSION} | |||
|
|||
# install nats-events plugin | |||
RUN pip install --no-cache-dir git+https://github.com/didx-xyz/aries-acapy-plugins@test-refactor-multitenant-manager-errors#subdirectory=nats_events | |||
RUN pip install --no-cache-dir git+https://github.com/didx-xyz/aries-acapy-plugins@nats-reconnect#subdirectory=nats_events |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to update this with a tagged release of the plugin, and then we can merge 👍 will do that later today
ff137
force-pushed
the
nats-reconnect-logic
branch
from
November 12, 2024 14:01
7864a91
to
a7db5d1
Compare
ff137
added a commit
that referenced
this pull request
Nov 14, 2024
* ⬆️ Upgrade to latest ACA-Py * ⬆️ Update lock files * 🐛 Nats reconnect logic (#1161) * rework nats init * 🎨 * remove broken test for now * remove while loop * reduce nats fetch timeout * 🎨 * remove import * re-add test * ⬆️ Upgrade to 1.1.1b3 ACA-Py image + plugins * ⬆️ Upgrade cloudcontroller to 1.1.1b3 release * ⬆️ Update lock files * ✨ Update to use new limit/offset params, instead of count/start * ⬆️ Update version for next release * test 1.1.1b4 * ⬆️ Upgrade protobuf version * ✨ Use stable releases of acapy agent and plugins * ⬆️ Upgrade aiohttp and update lock files * 🎨 Correct acapy-wallet-groups-plugin version tag * 🚧 test 1.1.1-20241115 * ✨ Enhance RichAsyncClient to retry on 502 errors as well * 🎨 Parameterise the retry wait duration * ⬆️ Upgrade plugins to next release --------- Co-authored-by: cl0ete <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add reconnect config to NATS.