-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 Remove redis, websockets, sse, and webhooks services #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K8s Regression Test Coverage
|
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 🔥 🔥
Removes redis-related scripts, config, and services.
Removes websocket endpoint, service and tests. And websocket related dependencies.
Removes deprecated webhooks endpoint.
Removes the sse functions that still used Webhooks URL. (Keeps the one that uses Waypoint)
And importantly, deletes all of the webhook module, and governance-webhooks-web dependency
🔥 🔥 🔥
Related charts PR: https://github.com/didx-xyz/charts/pull/301
Closes #962
Side notes:
standard
extra packages (no need for it -- it included a websocket dependency we no longer use).there's a deleted Webhooks.md doc that should be replaced with updated documentation(re-added)WEBHOOKS_TOPIC_ALL
,WEBHOOKS_URL
,WEBHOOKS_PUBSUB_URL
MAX_EVENT_AGE_SECONDS
,MAX_QUEUE_SIZE
,QUEUE_CLEANUP_PERIOD
,CLIENT_QUEUE_POLL_PERIOD
,SET_LOCKS
LAGO_URL
,LAGO_API_KEY
REDIS_NODES
look_back
SSE parameter. Can maybe be added later if there's need for it.