Add internal option for gear() #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… openscad.. hopefully openscad will fix this some day so we can have sliders again?
…eported bug in openscad
Minor changes to testing framework (by kintel)
Added 3d_triangle module
This reduces the amount of code required for drawing the screw, and speeds up rendering by quite a fair bit, since all our manual faceting happens in 2D.
trapezoidal_thread isn't called directly in most cases, and $fn doesn't seem to be passed properly from the higher level _thread modules, so use a max (30, ...) when calculating the number of facets to generate instead.
… 180/PI mm This lets us specify circular pitch in a much more sane manner when generating gears, while preserving backward compatibility.
This reverts commit 16128b6. The commit wrongly used the AC width as the distance between flats instead of the diameter of a cylinder, resulting in overly huge nut holes.
This simplifies the calculation of the distance between gears.
…ad file Thanks to Taahir Ahmed <[email protected]> for the idea.
Thanks to MichaelAtoZ for pointing this out.
If we're calculating gear spacing, there's no need to consider different circular pitches -- gaers of different circular pitch won't mesh.
This allows stepper.scad to be loaded via use <> instead of include <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option allows for the generation of internal spur gears. Internal mode
adapts the meanings of several options for use on internal gears:
cylinder.
pushes out the outer circle instead of pushing in the root circle.
radius.