fix for #10 #18
Open
fix for #10 #18
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a potential fix for the Issue #10.
The problem here was that the original implementation didn't really take the sort into account, how it should have to be. Therefore the minBound wasn't checked accordingly.
With my fix the minWidth is calculated with the Before/After Elements, but also has your previous fallback with a straight "+20".
Additionally to this:
There was a problem with multiple header-rows. Since we resize only the first one, I think this one will define the width. Instead of only resizing the dragged header-cell I resize now all cells within that column, to prevent any cell others than the first to interfere with the calculation of the minimum width.
If you have questions, don't hesitate! :)