perf(core): Introduce mutable map struct #9199
Open
+714
−214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/testing
harshil-goel
force-pushed
the
harshil-goel/mutable-map
branch
2 times, most recently
from
6fdd230
to
2f48d14
Compare
harshil-goel
changed the title
mangalaman93
requested changes
Oct 24, 2024
posting/list.go
Outdated
|
|
||
| mm.curTime = ts | ||
| mm.curList = pl | ||
| mm.uidMap = nil |
posting/list.go
Outdated
| } | ||
|
|
||
| for ts, pl := range mm.oldList { | ||
| if mm.curTime != 0 && ts > mm.curTime { |
There was a problem hiding this comment.
I don't think we need this. We should just merge with the below if
posting/list.go
Outdated
| mm.length = 0 | ||
| } | ||
| if mpost.Op == Del { | ||
| mm.length -= 1 |
There was a problem hiding this comment.
what if there is only deleteAll and nothing else? Can the length be -1 then?
hYuang
reviewed
Oct 26, 2024
harshil-goel
force-pushed
the
harshil-goel/mutable-map
branch
from
ad64584
to
8497e3d
Compare
harshil-goel
force-pushed
the
harshil-goel/mutable-map
branch
from
8497e3d
to
34d455d
Compare
shivaji-kharse
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the delta postings are being stored inside a map. When we are using cache, these deltas gets unnecessarily copied again and again because of the limitations of map. We have introduced a new struct, that would allow us to work on the list of
deltas.
With the introduction of this, we can now without copying the map, can pass around lists from one transaction to another without issue.
We are also going to store results like delete markers, uid to posting map and other stuff required to make queries go faster.