Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use identity.rs crates.io dependencies #66

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Use identity.rs crates.io dependencies #66

merged 2 commits into from
Oct 25, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Oct 25, 2024 •
edited
Loading

Motivation

We want to publish the ic-verifiable-credentials Rust SDK to crates.io

In this PR, we use the identity.rs dependencies from crates.io instead of the repository directly.

Changes

  • Add version instead of repo and commit for identity.rs dependencies.

Tests

Still passing.

Todos

  • Add entry to changelog (if necessary).

@lmuntaner lmuntaner requested a review from a team as a code owner October 25, 2024 07:38
frederikrothenberger
frederikrothenberger approved these changes Oct 25, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lmuntaner lmuntaner merged commit e15a716 into main Oct 25, 2024
8 checks passed
@lmuntaner lmuntaner deleted the lm-use-crates-identity-deps branch October 25, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger