-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extensions): dfx --help
lists installed extensions
#3096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericswanson-dfinity
requested changes
Apr 26, 2023
smallstepman
force-pushed
the
mnl/dfx-help-lists-extensions
branch
from
May 4, 2023 21:11
ace3298
to
985ce89
Compare
ericswanson-dfinity
requested changes
May 5, 2023
(standard commands are already sorted by clap)
smallstepman
force-pushed
the
mnl/dfx-help-lists-extensions
branch
from
May 8, 2023 21:51
e844865
to
9280321
Compare
smallstepman
force-pushed
the
mnl/dfx-help-lists-extensions
branch
from
May 8, 2023 22:08
9280321
to
45d8545
Compare
- install cache during e2e setup - install cache during dfx installation - at the beginning of running dfx, don't create extension directory if it doesn't exist
smallstepman
force-pushed
the
mnl/dfx-help-lists-extensions
branch
from
July 4, 2023 12:03
e256e3d
to
60d72e4
Compare
smallstepman
force-pushed
the
mnl/dfx-help-lists-extensions
branch
from
July 4, 2023 12:08
60d72e4
to
8f507e8
Compare
ericswanson-dfinity
requested changes
Jul 5, 2023
smallstepman
commented
Jul 6, 2023
smallstepman
force-pushed
the
mnl/dfx-help-lists-extensions
branch
from
July 6, 2023 20:37
7ba4ec8
to
8f77189
Compare
smallstepman
commented
Jul 6, 2023
smallstepman
force-pushed
the
mnl/dfx-help-lists-extensions
branch
from
July 7, 2023 01:16
2b47c20
to
b618e59
Compare
ericswanson-dfinity
requested changes
Jul 7, 2023
Co-authored-by: Eric Swanson <[email protected]>
ericswanson-dfinity
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor thing and gtg!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfx help
is issued (or -h or --help).extension.json
manifest intodfx
's command tree, allowing for callinghelp
/-h
/--help
on any of the extensions subcommands without actually running themCloses https://dfinity.atlassian.net/browse/SDK-1088
How Has This Been Tested?
e2e + unit + manually
Checklist:
I have edited the CHANGELOG accordingly.I have made corresponding changes to the documentation.