Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extensions): dfx --help lists installed extensions #3096

Merged
merged 59 commits into from
Jul 8, 2023

Conversation

smallstepman
Copy link
Contributor

@smallstepman smallstepman commented Apr 19, 2023

Description

  • Installed extensions are printed when dfx help is issued (or -h or --help).
    image
  • Parses extensions subcommands (and their args) from extension.json manifest into dfx's command tree, allowing for calling help/-h/--help on any of the extensions subcommands without actually running them
    image

Closes https://dfinity.atlassian.net/browse/SDK-1088

How Has This Been Tested?

e2e + unit + manually

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@smallstepman smallstepman marked this pull request as ready for review April 25, 2023 14:28
@smallstepman smallstepman requested a review from a team as a code owner April 25, 2023 14:28
src/dfx/src/main.rs Outdated Show resolved Hide resolved
@smallstepman smallstepman force-pushed the mnl/dfx-help-lists-extensions branch from ace3298 to 985ce89 Compare May 4, 2023 21:11
@smallstepman smallstepman force-pushed the mnl/dfx-help-lists-extensions branch from e844865 to 9280321 Compare May 8, 2023 21:51
Marcin Nowak-Liebiediew added 2 commits May 9, 2023 13:10
- install cache during e2e setup
- install cache during dfx installation
- at the beginning of running dfx, don't create extension directory if
  it doesn't exist
@smallstepman smallstepman marked this pull request as draft May 10, 2023 16:29
@smallstepman smallstepman force-pushed the mnl/dfx-help-lists-extensions branch from e256e3d to 60d72e4 Compare July 4, 2023 12:03
@smallstepman smallstepman force-pushed the mnl/dfx-help-lists-extensions branch from 60d72e4 to 8f507e8 Compare July 4, 2023 12:08
src/dfx/src/main.rs Outdated Show resolved Hide resolved
@smallstepman smallstepman force-pushed the mnl/dfx-help-lists-extensions branch from 7ba4ec8 to 8f77189 Compare July 6, 2023 20:37
@smallstepman smallstepman force-pushed the mnl/dfx-help-lists-extensions branch from 2b47c20 to b618e59 Compare July 7, 2023 01:16
src/dfx/src/lib/deps/mod.rs Outdated Show resolved Hide resolved
Marcin Nowak-Liebiediew and others added 2 commits July 7, 2023 19:09
Copy link
Member

@ericswanson-dfinity ericswanson-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing and gtg!

src/dfx/src/lib/error/extension.rs Outdated Show resolved Hide resolved
@smallstepman smallstepman enabled auto-merge (squash) July 8, 2023 00:21
@smallstepman smallstepman merged commit 44ff699 into master Jul 8, 2023
292 checks passed
@smallstepman smallstepman deleted the mnl/dfx-help-lists-extensions branch July 8, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants