[FINAL] feat: WASM heap memory limit for canisters #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
commented
Feb 26, 2024
mraszyk
commented
Feb 26, 2024
Dfinity-Bjoern
approved these changes
Feb 27, 2024
ulan
reviewed
Apr 17, 2024
ulan
added a commit
to dfinity/cdk-rs
that referenced
this pull request
Apr 17, 2024
This adds `wasm_memory_limit` to `CanisterSettings` and `DefiniteCanisterSettings`. The corresponding spec change: - dfinity/interface-spec#278
|
@mraszyk: could you please merge this PR? The replica supports the feature now. Rust CDK and agent changes are blocked by this spec PR being merged according to the SDK team. |
mraszyk
changed the title
lwshang
added a commit
to dfinity/cdk-rs
that referenced
this pull request
Apr 19, 2024
* feat: Add `wasm_memory_limit` to the management canister This adds `wasm_memory_limit` to `CanisterSettings` and `DefiniteCanisterSettings`. The corresponding spec change: - dfinity/interface-spec#278 * Add the PR number to the change log * unify doc format * better test coverage --------- Co-authored-by: Linwei Shang <[email protected]>
mraszyk
commented
May 7, 2024
mraszyk
commented
May 7, 2024
mraszyk
commented
May 7, 2024
mraszyk
commented
May 7, 2024
mraszyk
commented
May 7, 2024
|
@ulan There seem to be some mismatches between the spec and the implementation - could you please take a look at my above comments? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a configurable WASM heap memory limit for canisters.