feat: Best-effort responses #268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure scalability, we want to allow canister authors to use best-effort responses to inter-canister calls, which time out after a period of time. Details are in IC-1674 and the forum post: https://forum.dfinity.org/t/scalable-messaging-model/26920
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Alin Sinpalean <[email protected]>
To prevent the reader from wondering what the reason for the reordering is
Otherwise we force the callee to process a request whenever a SYS_UNKNOWN is returned.
mraszyk
reviewed
Mar 5, 2024
mraszyk
reviewed
Mar 5, 2024
rsundar01
reviewed
Apr 2, 2024
mraszyk
reviewed
Apr 2, 2024
mraszyk
reviewed
Apr 2, 2024
mraszyk
reviewed
Apr 2, 2024
mraszyk
reviewed
Apr 2, 2024
mraszyk
reviewed
Apr 2, 2024
oggy-dfin
commented
Apr 2, 2024
Co-authored-by: mraszyk <[email protected]>
Needed to still be able to return a deadline in ic0.msg_deadline
Will move it to a separate PR
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
mraszyk
reviewed
Oct 3, 2024
mraszyk
reviewed
Oct 3, 2024
Co-authored-by: mraszyk <[email protected]>
Co-authored-by: mraszyk <[email protected]>
After experimenting with the current implementation, it turns out that we always return a deadline of 0 in all query and replicated query calls (regardless of whether we use ingress, composite queries, or replicated execution)
mraszyk
reviewed
Oct 7, 2024
mraszyk
reviewed
Oct 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: mraszyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure scalability, we want to allow canister authors to use best-effort responses to inter-canister calls, which time out after a period of time.
Details are in IC-1674 and the forum post:
https://forum.dfinity.org/t/scalable-messaging-model/26920