Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IC-1243) Install large wasm #219

Merged
merged 124 commits into from
Oct 10, 2023
Merged

(IC-1243) Install large wasm #219

merged 124 commits into from
Oct 10, 2023

Conversation

bogwar
Copy link
Contributor

@bogwar bogwar commented Aug 14, 2023

This PR introduces the API changes needed to support installing large Wasms

Dfinity-Bjoern and others added 30 commits August 5, 2021 14:59
* Add heartbeat to spec

* Terminology changes in release 0.18.2

* Add support for 64-bit stable memory
* ic-ref-test: Pass cycles with 10-controllers-test

* Remove reference implementation (#348)

it has been open sourced and moved to https://github.com/dfinity/ic-hs.

* Release version 0.18.1 (#364)

* Release 0.18.2 (#372)

* Add heartbeat to spec

* Terminology changes in release 0.18.2

* Add support for 64-bit stable memory

Co-authored-by: Joachim Breitner <[email protected]>
* Prepare release 0.18.3

* Remove redundant comment

* Update spec/index.adoc

Co-authored-by: Jens Groth <[email protected]>

* Update spec/index.adoc

Co-authored-by: Jens Groth <[email protected]>

* Reformulation

Co-authored-by: Jens Groth <[email protected]>
Fix exponentiations 2^n -> 2^n^
spec/index.md Outdated Show resolved Hide resolved
@Dfinity-Bjoern
Copy link
Member

Overall looks good, let's discuss on Tuesday!

@crusso
Copy link
Contributor

crusso commented Sep 12, 2023

Sorry, I was just looking over this and noticed that my comments were merely pending, so I must have failed to submit my review when I made the comments weeks ago.

@bogwar bogwar changed the title Bogwar/largewasm (IC-1243) Install large wasm Oct 2, 2023
spec/index.md Outdated Show resolved Hide resolved
spec/index.md Outdated Show resolved Hide resolved
Copy link
Member

@Dfinity-Bjoern Dfinity-Bjoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is matured now.

@bogwar bogwar merged commit d780e54 into master Oct 10, 2023
3 checks passed
gitlab-dfinity pushed a commit to dfinity/ic that referenced this pull request Oct 25, 2023
RUN-735: Implement InstallChunkedCode

Add new management canister message to support installing a wasm module
from chunks stored in the WasmChunkStore of a canister on the same
subnet. Corresponding changes here: dfinity/interface-spec#219 

See merge request dfinity-lab/public/ic!15150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants