-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(IC-1243) Install large wasm #219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add heartbeat to spec * Terminology changes in release 0.18.2 * Add support for 64-bit stable memory
* ic-ref-test: Pass cycles with 10-controllers-test * Remove reference implementation (#348) it has been open sourced and moved to https://github.com/dfinity/ic-hs. * Release version 0.18.1 (#364) * Release 0.18.2 (#372) * Add heartbeat to spec * Terminology changes in release 0.18.2 * Add support for 64-bit stable memory Co-authored-by: Joachim Breitner <[email protected]>
* Prepare release 0.18.3 * Remove redundant comment * Update spec/index.adoc Co-authored-by: Jens Groth <[email protected]> * Update spec/index.adoc Co-authored-by: Jens Groth <[email protected]> * Reformulation Co-authored-by: Jens Groth <[email protected]>
Fix exponentiations 2^n -> 2^n^
Co-authored-by: Jens Groth <[email protected]>
Release version 0.18.4
Publish release 0.18.4
Issue release 0.18.5
Publish interface spec 0.18.5
Overall looks good, let's discuss on Tuesday! |
Sorry, I was just looking over this and noticed that my comments were merely pending, so I must have failed to submit my review when I made the comments weeks ago. |
…into bogwar/largewasm
mraszyk
reviewed
Oct 2, 2023
mraszyk
reviewed
Oct 6, 2023
Dfinity-Bjoern
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is matured now.
gitlab-dfinity
pushed a commit
to dfinity/ic
that referenced
this pull request
Oct 25, 2023
RUN-735: Implement InstallChunkedCode Add new management canister message to support installing a wasm module from chunks stored in the WasmChunkStore of a canister on the same subnet. Corresponding changes here: dfinity/interface-spec#219 See merge request dfinity-lab/public/ic!15150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the API changes needed to support installing large Wasms