Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update/query macro could not handle function arguments with the same name as the function itself #525

Merged
merged 3 commits into from
Oct 11, 2024
Merged

fix: update/query macro could not handle function arguments with the same name as the function itself #525

merged 3 commits into from
Oct 11, 2024

Conversation

lwshang
Copy link
Contributor

@lwshang lwshang commented Oct 11, 2024

SDK-1856

How Has This Been Tested?

ic-cdk/tests/pass/method_arg_same_name.rs

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@lwshang lwshang marked this pull request as ready for review October 11, 2024 16:04
@lwshang lwshang requested a review from a team as a code owner October 11, 2024 16:04
@lwshang lwshang merged commit 69d98b0 into next Oct 11, 2024
8 checks passed
@lwshang lwshang deleted the lwshang/SDK-1856 branch October 11, 2024 20:18
@lwshang lwshang mentioned this pull request Oct 11, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lwshang