Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ld-compatible symbols #500

Merged
merged 3 commits into from
Jul 5, 2024
Merged

fix: ld-compatible symbols #500

merged 3 commits into from
Jul 5, 2024

Conversation

adamspofford-dfinity
Copy link
Contributor

This changes export macros to not contain spaces or brackets, so cargo build doesn't give weird errors with GNU ld.

@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner July 5, 2024 17:50
@lwshang lwshang merged commit 5ae0552 into main Jul 5, 2024
18 checks passed
@lwshang lwshang deleted the spofford/host-compat branch July 5, 2024 19:27
@adamspofford-dfinity adamspofford-dfinity mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwshang lwshang lwshang approved these changes

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamspofford-dfinity @lwshang @ericswanson-dfinity