Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support log_visibility canister setting #497

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented Jun 27, 2024

Description

Canister settings now include log_visibility.

Addresses feature request on the forum

How Has This Been Tested?

Covered in a test

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested a review from a team as a code owner June 27, 2024 11:17
@sesi200 sesi200 enabled auto-merge (squash) June 27, 2024 11:49
@sesi200 sesi200 merged commit 8857ee4 into main Jun 27, 2024
18 checks passed
@sesi200 sesi200 deleted the severin/log-visibility branch June 27, 2024 20:50
github-merge-queue bot pushed a commit to dfinity/ic that referenced this pull request Oct 8, 2024
Relevant breaking changes from
[`ic-cdk`](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md):
1. [[0.15.0]]([0.15.0]): 
1. BREAKING: Stable Memory always use 64-bit addresses and stable64_*
system API. (dfinity/cdk-rs#498)
2. BREAKING: Add log_visibility to the management canister API types:
(dfinity/cdk-rs#497)
        - CanisterSettings
        - DefiniteCanisterSettings.
3.
[[0.13.3]](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md#0133---2024-05-10-yanked)
BREAKING: Add wasm_memory_limit to the management canister API types:
(dfinity/cdk-rs#483)
    - CanisterSettings
    - DefiniteCanisterSettings.

---------

Co-authored-by: IDX GitHub Automation <[email protected]>
nikolay-komarevskiy pushed a commit to dfinity/ic that referenced this pull request Oct 11, 2024
Relevant breaking changes from
[`ic-cdk`](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md):
1. [[0.15.0]]([0.15.0]): 
1. BREAKING: Stable Memory always use 64-bit addresses and stable64_*
system API. (dfinity/cdk-rs#498)
2. BREAKING: Add log_visibility to the management canister API types:
(dfinity/cdk-rs#497)
        - CanisterSettings
        - DefiniteCanisterSettings.
3.
[[0.13.3]](https://github.com/dfinity/cdk-rs/blob/main/src/ic-cdk/CHANGELOG.md#0133---2024-05-10-yanked)
BREAKING: Add wasm_memory_limit to the management canister API types:
(dfinity/cdk-rs#483)
    - CanisterSettings
    - DefiniteCanisterSettings.

---------

Co-authored-by: IDX GitHub Automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants