Fix edge case with wrong children normalizing

dfilatov · Dec 10, 2019 · 48eb094 · 48eb094
1 parent fc299ab
commit 48eb094
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/spec/normalizeNode/normalizeNode.spec.js b/spec/normalizeNode/normalizeNode.spec.js
@@ -112,6 +112,14 @@ describe('normalizeNode', () => {
             .to.be.eql(node);
     });
 
+    it('should not modify array child', () => {
+        const child = [h('a')];
+
+        normalizeNode([child, h('b')]);
+
+        expect(child).to.have.length(1);
+    });
+
     it('should reuse existing array if possible', () => {
         const children = [h('a'), h('b')];
 

diff --git a/src/nodes/utils/normalizeNode.js b/src/nodes/utils/normalizeNode.js
@@ -51,7 +51,7 @@ export default function normalizeNode(obj) {
                     (res === obj?
                         res.slice(0, i) :
                         Array.isArray(res)? res : [nodeToElement(res)]).concat(child) :
-                    child;
+                    child.slice();
             }
             else if(res !== obj) {
                 if(!hasContentBefore) {