Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several questions about code base actuality #26

Open
qfox opened this issue Jan 22, 2016 · 5 comments
Open

Several questions about code base actuality #26

qfox opened this issue Jan 22, 2016 · 5 comments

Comments

@qfox
Copy link

qfox commented Jan 22, 2016

  1. hasIntrospection looks like useless check at the moment: https://github.com/dfilatov/inherit/blob/master/lib/inherit.js#L10
  2. Why not to use shims for Object.create, Object.keys, Object.assign (extend), etc.
  3. Can we remove or replace comment with obscene lexic? https://github.com/dfilatov/inherit/blob/master/lib/inherit.js#L43
  4. https://github.com/dfilatov/inherit/blob/master/lib/inherit.js#L49 — it is the same as Object.keys, right?
  5. Why not to use noOp as emptyBase? They are both empty functions.
@dfilatov
Copy link
Owner

  1. Yes, seems it can be removed.
  2. What's the point?
  3. Yes, we can.
  4. No, it's not. Object.keys is used inside it.
  5. Seems that emptyBase can be replaced with noOp.

@qfox
Copy link
Author

qfox commented Jan 25, 2016

1, 3, 5. Great, can we make PR for it?
2. To reduce code base, since inherit library still used in the last i-bem.
4. Feels like it depends on polyfill we use. https://github.com/es-shims/es5-shim/blob/master/es5-shim.js#L948 https://github.com/es-shims/es5-shim/blob/master/es5-shim.js#L1042 versus https://github.com/bem/es5-shims/blob/master/common.blocks/ecma/__object/ecma__object.js#L4

@dfilatov
Copy link
Owner

1, 3, 5. Yes, we can :)
2, 4. Looks unhelpful to me

@ilyar ilyar mentioned this issue Jun 8, 2017
@ilyar
Copy link
Contributor

ilyar commented Jun 8, 2017

@zxqfox @dfilatov 1, 3, 5 ready in #37

@qfox
Copy link
Author

qfox commented Jun 8, 2017

Great news! I've lost this....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants