Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add uniqueID to all entities and save using actorstorage #754

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olebeck
Copy link

@olebeck olebeck commented Mar 14, 2023

implementing https://learn.microsoft.com/en-us/minecraft/creator/documents/actorstorage
this is how the game stores entities so now entities saved from dragonfly show up when the world is loaded in single player
and entities in worlds from singleplayer show up in dragonfly.
also checks for the old keyEntities based entity data for loading older worlds, i couldnt test that since i dont have an older world but it should work.

@Sandertv
Copy link
Member

Hi! First of all, thank you for the PR! It is very much appreciated.

Unfortunately, however, we are trying to make some changes to entities to reduce the amount of boilerplate code. As you were probably able to tell with this PR, you had to add the unique ID to every one of the entities individually, which is far from ideal. I'm hoping to come up with a system for entities where we can share more code so that this isn't necessary, but doing so isn't very easy hence the lack of progress.

For now, I'm going to keep this open. I would like to merge it at some point, but ideally once we can get entities themselves to a bit of a better point.

@olebeck
Copy link
Author

olebeck commented Mar 30, 2023

ok that sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants