Big PR on keeping libmpsse alive #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that calling the SetDirection function from python led to an TypeError due to the uint8_t parameter int SetDirection(struct mpsse_context *mpsse, uint8_t direction); I found the solution on stack exchange, recompiled, and confirmed that the error disappeared. https://stackoverflow.com/questions/8897294/swig-python-c-how-to-use-type-int8-t
Partial reads can be can be correct. Implement same behaviour for Transfer() Return NULL on errors.
Fixes warnings like: cc: warning: -lftdi: 'linker' input unused
files & non-swig. This can help fix parallel builds - building with incorrect object file or trying to link with files that are still being written. See devttys0#16
Signed-off-by: Sergey Alirzaev <[email protected]>
… below that. Signed-off-by: Sergey Alirzaev <[email protected]>
Signed-off-by: Sergey Alirzaev <[email protected]>
now it works for Gentoo
added -DLIBFTDI1 to fast.c compiler options for compilation on fedora
migrate README to markdown
meanwhile making -Wextra happy
as suggested by devttys0#36 and #4 (comment)
Also, define _POSIX_C_SOURCE in Makefile.in to get rid of the compiler warning.
This is a large change, but since it involved the changes to the build system, it is extremely hard to split into smaller chunks. Use automake to generate makefiles. This documentation was used to write build rules for python wrappers in Makefile.am: https://github.com/swig/swig/wiki/FAQ#autotools-integration configure.ac rewritten substantially to use existing checks and canonical m4sh constructs, where applicable. The check for LibFTDI version in the source code has been changed to a canonical "HAVE_LIBFTDI".
- Package "libtool" must be installed - "autoreconf --install" is necessary to create missing files - config.h must be created
as seen in #16
The bug should never happen, but the convoluted logic of fast_build_block_buffer makes it difficult for the compiler to understand it.
Verified with FT4232H Mini Module.
uses the internal structure of libftdi as seen in https://www.intra2net.com/en/developer/libftdi/documentation/ftdi_8c_source.html#l00091 fixes #7
This reverts commit bf2cafe. apparently libftdi in Ubuntu 16.04.6 doesn't provide that hack
just get plenty of ftdi errors but whatever fixes #7
Don't look for swig or python if the flag --disable-python is used. This allows to have a minimalistic build environment without a python installation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to send your PR's to https://github.com/l29ah/libmpsse/