Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email-template-subject #6057

Merged

Conversation

shivani170
Copy link
Contributor

@shivani170 shivani170 commented Nov 7, 2024

  • implemented rollback for the helm having no gitops case

  • removed some checks

  • refactored the code and made compatible for gitops case too

  • after refactoring

  • resolved the comments

  • removed unwanted commented code

  • resolved the comments

  • resolved the comments

  • executed make after merging develop

Description

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1105

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


iamayushm
iamayushm previously approved these changes Nov 7, 2024
iamayushm
iamayushm previously approved these changes Nov 7, 2024
@shivani170 shivani170 changed the title Feat/email-template-subject fix: email-template-subject Nov 7, 2024
iamayushm
iamayushm previously approved these changes Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

@iamayushm iamayushm merged commit 4bd5d91 into devtron-labs:develop Nov 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants