-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: email-template-subject #6057
Merged
iamayushm
merged 11 commits into
devtron-labs:develop
from
shivani170:feat/email-template-subject
Nov 7, 2024
Merged
fix: email-template-subject #6057
iamayushm
merged 11 commits into
devtron-labs:develop
from
shivani170:feat/email-template-subject
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivani170
requested review from
prakarsh-dt,
vikramdevtron and
nishant-d
as code owners
November 7, 2024 02:55
iamayushm
reviewed
Nov 7, 2024
scripts/sql/29902200_appoval_email_template_subject_update.down.sql
Outdated
Show resolved
Hide resolved
iamayushm
previously approved these changes
Nov 7, 2024
iamayushm
previously approved these changes
Nov 7, 2024
scripts/sql/29902200_appoval_email_template_subject_update.down.sql
Outdated
Show resolved
Hide resolved
iamayushm
previously approved these changes
Nov 7, 2024
Quality Gate passedIssues Measures |
vivek-devtron
approved these changes
Nov 7, 2024
vikramdevtron
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented rollback for the helm having no gitops case
removed some checks
refactored the code and made compatible for gitops case too
after refactoring
resolved the comments
removed unwanted commented code
resolved the comments
resolved the comments
executed make after merging develop
Description
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1105
Checklist:
Does this PR introduce a user-facing change?