Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for templates in external secrets #5856

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Added support for templates in external secrets #5856

wants to merge 4 commits into from

Conversation

pawan-mehta-dt
Copy link
Contributor

@pawan-mehta-dt pawan-mehta-dt commented Sep 18, 2024 •
edited
Loading

Description

Added support for subPath and templates in external secrets

Fixes #5861

How Has This Been Tested?

  • Tested on separate devtron instance

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pawan-mehta-dt pawan-mehta-dt changed the title feat: Added support for subPath and templates in external secrets feat: Added support for templates in external secrets Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakarsh-dt prakarsh-dt Awaiting requested review from prakarsh-dt prakarsh-dt is a code owner

@nishant-d nishant-d Awaiting requested review from nishant-d nishant-d is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
PR:Ready-to-Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Added support for templates in external secrets
1 participant
@pawan-mehta-dt