LibJS: Change URL and name to reflect move to LadybirdBrowser/ladybird #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows CI failures unrelated (LibJS doesn't support windows anyway :D ) |
|
@ADKaster i fixed the windows ci so you should be able to rebase main now |
Development of the cross-platform parts of LibWeb/LibJS/LibWasm for the Ladybird Browser project has split off into a new repository. Point esvu to the new repository and its artifacts
ADKaster
force-pushed
the
ladybird-browser-libjs
branch
from
f3ed83b to
e5b455a
Compare
BertalanD
added a commit
to BertalanD/serenity
that referenced
this pull request
Jul 7, 2024
As of devsnek/esvu#57, `esvu` now pulls the LibJS binaries from the Ladybird repo, so these artifacts being created has no purpose. As far as I can tell, nothing else uses them. Maybe if the two LibJS versions start going their separate ways enough to warrant both being available, we could consider re-adding this job. But no point in using up CI resources for that right now.
ADKaster
pushed a commit
to SerenityOS/serenity
that referenced
this pull request
Jul 7, 2024
As of devsnek/esvu#57, `esvu` now pulls the LibJS binaries from the Ladybird repo, so these artifacts being created has no purpose. As far as I can tell, nothing else uses them. Maybe if the two LibJS versions start going their separate ways enough to warrant both being available, we could consider re-adding this job. But no point in using up CI resources for that right now.
alimpfard
pushed a commit
to alimpfard/serenity
that referenced
this pull request
Jul 15, 2024
As of devsnek/esvu#57, `esvu` now pulls the LibJS binaries from the Ladybird repo, so these artifacts being created has no purpose. As far as I can tell, nothing else uses them. Maybe if the two LibJS versions start going their separate ways enough to warrant both being available, we could consider re-adding this job. But no point in using up CI resources for that right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development of the cross-platform parts of LibWeb/LibJS/LibWasm for the Ladybird Browser project has split off into a new repository.
Point esvu to the new repository and its artifacts