Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#931: enhance settings in code repository #983

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

salimbouch
Copy link
Contributor

fixes #931

  • No more Missing .git folder in D:\projects\code-demo\settings.
  • When the settings repository is a symlink, ide update skips the pull operation. When force mode is active, the pull operation is still performed.

@salimbouch salimbouch self-assigned this Jan 23, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12993675654

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 141 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.006%) to 68.45%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/git/GitOperation.java 3 90.22%
com/devonfw/tools/ide/commandlet/StatusCommandlet.java 5 56.45%
com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java 6 82.44%
com/devonfw/tools/ide/context/IdeContext.java 8 63.92%
com/devonfw/tools/ide/context/AbstractIdeContext.java 119 59.34%
Totals Coverage Status
Change from base Build 12950192250: 0.006%
Covered Lines: 7211
Relevant Lines: 10140

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salimbouch thanks for your PR. You did a great job at got everything right 👍
I added one small suggestion for improvement and another review comment to avoid further diff-wars. Please have a look and update. Then ready for merge.

@hohwille hohwille added this to the release:2025.01.002 milestone Jan 23, 2025
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hohwille hohwille merged commit 05af7d1 into devonfw:main Jan 27, 2025
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix git reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Enhance settings in code repository
4 participants