Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#915: fix custom tools #918

Merged
merged 6 commits into from
Jan 16, 2025
Merged

#915: fix custom tools #918

merged 6 commits into from
Jan 16, 2025

Conversation

hohwille
Copy link
Member

fixes #915

@hohwille hohwille added update related to updating software or the entire ide install installation process of IDE + tools and install commandlet bugfix custom ide-custom-tools.json and related features labels Jan 13, 2025
@hohwille hohwille added this to the release:2025.01.001 milestone Jan 13, 2025
@hohwille hohwille self-assigned this Jan 13, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12807758441

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 81 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 67.83%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/CustomToolCommandlet.java 6 0.0%
com/devonfw/tools/ide/context/AbstractIdeContext.java 75 62.19%
Totals Coverage Status
Change from base Build 12807241459: -0.02%
Covered Lines: 6969
Relevant Lines: 9905
💛 - Coveralls

alfeilex
alfeilex approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@alfeilex alfeilex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hohwille hohwille merged commit 93247a4 into devonfw:main Jan 16, 2025
4 checks passed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfeilex alfeilex alfeilex approved these changes

Assignees

@hohwille hohwille

Labels
bugfix custom ide-custom-tools.json and related features install installation process of IDE + tools and install commandlet reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. update related to updating software or the entire ide
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2025.01.001
Development

Successfully merging this pull request may close these issues.

custom-tools not working
3 participants
@hohwille @coveralls @alfeilex