#898: Improved output of get-version/edition and uninstall/-plugin #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2024 12:57
Edition/VersionGetCommandlet changed them to log the configured option if the tool is not installed and the installed option if it is installed. Changed the toolInstallInfo method to log into IdeSublogger instead of using context.info or context.warning. Changed the uninstall commandlet to log a warning in case the requested commandlet is not installed. Changed the uninstallPlugin commandlet to give feedback wether the plugin could be deleted or if there was not installation found. Adjusted Tests for Edition/VersionGetCommandlet as well as Uninstall commandlet to expect the correct loglevel or content of logged messages. Added logAtProccessable to IdeTestContextAssertions to check if a log-message was logged on PROCESSABLE-level. Added .ide.software.version file to the npm software in the basic ide-test-project-ressource, since it was needed to test my implementation.
added CHANGELOG entry
Pull Request Test Coverage Report for Build 12816835423Details
💛 - Coveralls |
hohwille
reviewed
Dec 20, 2024
cli/src/main/java/com/devonfw/tools/ide/commandlet/VersionGetCommandlet.java
Outdated
Show resolved
Hide resolved
|
@jan-vcapgemini please have a look. |
So if I get this correct, the test was expecting the message |
hohwille
changed the title
hohwille
requested changes
Jan 7, 2025
cli/src/main/java/com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/EditionGetCommandletTest.java
Outdated
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/EditionGetCommandletTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.adoc # cli/src/main/java/com/devonfw/tools/ide/io/FileAccess.java
adjusted tests adjusted log messages adjusted error messages
adjusted tests
adjusted tests
hohwille
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
@jan-vcapgemini thanks for taking over this PR. You did a really awesome job here 👍
I only added minor suggestions but one review comment seems to indicate some kind of bug that we should discuss and if confirmed fix before merging.
cli/src/main/java/com/devonfw/tools/ide/commandlet/AbstractVersionOrEditionGetCommandlet.java
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/EditionGetCommandletTest.java
Show resolved
Hide resolved
cli/src/test/java/com/devonfw/tools/ide/commandlet/EditionGetCommandletTest.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/commandlet/AbstractVersionOrEditionGetCommandlet.java
Outdated
Show resolved
Hide resolved
…sionOrEditionGetCommandlet.java
made sure that all get tests will not copy test resources enhanced edition basic test description
|
Thanks for fast and final perfection of this PR. |
hohwille
added a commit
to hohwille/IDEasy
that referenced
this pull request
Jan 20, 2025
…sing other tests to turn red as side effect
hohwille
added a commit
that referenced
this pull request
Jan 20, 2025
…her tests to turn red as side effect (#955)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #898
Edition/VersionGetCommandlet changed them to log the configured option if the tool is not installed and the installed option if it is installed.
Changed the toolInstallInfo method to log into IdeSublogger instead of using context.info or context.warning.
Changed the uninstall commandlet to log a warning in case the requested commandlet is not installed.
Changed the uninstallPlugin commandlet to give feedback wether the plugin could be deleted or if there was not installation found.
Adjusted Tests for Edition/VersionGetCommandlet as well as Uninstall commandlet to expect the correct loglevel or content of logged messages.
Added logAtProccessable to IdeTestContextAssertions to check if a log-message was logged on PROCESSABLE-level.
Added .ide.software.version file to the npm software in the basic ide-test-project-ressource, since it was needed to test my implementation.