#764: Fix IDEasy for CMD by adding Git related entries into PATH

[alfeilex]

Fixes: #764

Tested using:

• Windows 10
• CMD, PowerShell
• Git-Version: 2.47.1.windows.1
• ide create <project>, ide -f intellij, ide intellij

[coveralls]

Pull Request Test Coverage Report for Build 12411555241

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 67.478%

---

Totals
Change from base Build 12375027220:	0.0%
Covered Lines:	6656
Relevant Lines:	9523

---

💛 - Coveralls

[alfeilex]

IDEasy/cli/src/main/package/bin/ide.bat

Lines 27 to 29 in d36317e

	if not %ERRORLEVEL% == 0 (
	echo IDE environment variables have been set for %IDE_HOME% in workspace %WORKSPACE%
	)

Is the condition right here?

[hohwille]

@alfeilex thanks for your PR and fixing this bug. 👍
As a quickfix your changes should already work, but we need some more robustness for it.
Please have a look at my comment.

[hohwille]

IDEasy/cli/src/main/package/bin/ide.bat

Lines 27 to 29 in d36317e

	if not %ERRORLEVEL% == 0 (
	echo IDE environment variables have been set for %IDE_HOME% in workspace %WORKSPACE%
	)

Is the condition right here?

Very good point. We actually want the exit code of ideasy env command but we are directly processing the output of it and invoking call set %%i in the loop. Maybe the ERRORLEVEL will be overridden by that command inside the loop.
Coding CMD is actually even 10 dimensions worse to coding bash what can already be some kind of nightmare itself.
But solving this problem in bash would be very easy and doing the same in CMD could be tricky - at least I have no clue how to do it.
I just did a simple test:

C:\Users\hohwille>ide


C:\Users\hohwille>d:

D:\>cd projects

D:\projects>cd IDEasy

D:\projects\IDEasy>ide

D:\projects\IDEasy>

So it seems this condition is never met and the message is never printed out at all.
We need to create a separate bug issue for this.

UPDATE: I created bug #894 for this problem since it is unrelated to the GIT PATH issue.

[hohwille]

ready for merge 👍