Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#759: upgrade settings commandlet #820

Open
wants to merge 89 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 85 commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
7af9fc5
#765: Fix typos in DoD asciidoc
Oct 2, 2024
aeae1dd
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Oct 17, 2024
e520d16
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Oct 25, 2024
29403d3
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Oct 25, 2024
5bff5eb
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Oct 28, 2024
890c107
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Oct 29, 2024
c55af62
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Oct 31, 2024
3be67d0
#737: Added cd command to shell commandlet
leonrohne27 Nov 6, 2024
60f2e8a
Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…
leonrohne27 Nov 6, 2024
5224bf9
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 7, 2024
02cdeb0
Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…
jan-vcapgemini Nov 7, 2024
d925977
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 8, 2024
2d41161
Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…
jan-vcapgemini Nov 11, 2024
4a8f60b
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 12, 2024
1a6cdb8
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 13, 2024
bad672f
Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…
jan-vcapgemini Nov 14, 2024
f79c030
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 14, 2024
3d2b190
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 14, 2024
e1854bb
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 15, 2024
b85ca18
Merge branch 'main' into implement/737-add-cd-command-to-shell-comman…
jan-vcapgemini Nov 18, 2024
51dd0c2
Update cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellComman…
leonrohne27 Nov 19, 2024
0bd754c
Update cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellComman…
leonrohne27 Nov 19, 2024
0302acf
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 19, 2024
1af2948
#737: optimized cd command
leonrohne27 Nov 19, 2024
ec4d5f6
#737: optimized cd command
leonrohne27 Nov 19, 2024
06e9b8a
#737: Added Changelog entry
leonrohne27 Nov 19, 2024
4602866
#759:
leonrohne27 Nov 19, 2024
7bb5674
kian ist der best
KianRolf Nov 19, 2024
50b9fb2
#759: listchildrenrecursive
KianRolf Nov 20, 2024
07ae66e
#759: rename
leonrohne27 Nov 20, 2024
709cb34
#759: check
KianRolf Nov 20, 2024
ad841a9
#759: delete devon.properties
leonrohne27 Nov 20, 2024
1410aaa
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 21, 2024
09ecb53
#759
leonrohne27 Nov 21, 2024
9a6d662
#759
leonrohne27 Nov 21, 2024
0ab3f49
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 22, 2024
bb75cf9
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 22, 2024
72a720c
#759: Added CheckIfLegacyFolderExists() method
leonrohne27 Nov 25, 2024
47b8ead
#759: combine
KianRolf Nov 25, 2024
a2e3ca9
#759
KianRolf Nov 25, 2024
374a059
#759:
leonrohne27 Nov 25, 2024
af2842e
#759: Added recursive variable replacement
leonrohne27 Nov 25, 2024
78c2fad
#759: Added method that deletes file
leonrohne27 Nov 25, 2024
c51ef83
#759: merge
KianRolf Nov 25, 2024
c5c4324
#759:small fix
KianRolf Nov 25, 2024
bb0c401
#759
leonrohne27 Nov 25, 2024
d8d2a81
#759: Added checkForXMLNameSpace()-method
leonrohne27 Nov 26, 2024
1a55e15
#759
leonrohne27 Nov 26, 2024
8fad8d0
#759: custom-json-file
KianRolf Nov 27, 2024
3668654
Merge branch 'main' of https://github.com/KianRolf/IDEasy
KianRolf Nov 27, 2024
b41dcc7
#759: small changes
leonrohne27 Nov 27, 2024
79c2ff3
#759: Added documentation
leonrohne27 Nov 27, 2024
23b24b5
#759:
leonrohne27 Nov 27, 2024
44bfb40
#759: clean up
leonrohne27 Nov 27, 2024
ba49f5f
#759:clean up and reformat
KianRolf Nov 27, 2024
3c5a53e
#759
leonrohne27 Nov 27, 2024
a6d4e94
#759: performance improvement
KianRolf Nov 28, 2024
0f34d7d
Merge branch 'main' into implement/759-UpgradeSettingsCommandlet
KianRolf Nov 28, 2024
27f317c
#759: remove
KianRolf Nov 28, 2024
5159b15
#759: remove
KianRolf Nov 28, 2024
2733362
#759
leonrohne27 Nov 28, 2024
a5817db
Merge branch 'main' into implement/759-UpgradeSettingsCommandlet
leonrohne27 Nov 28, 2024
195f190
#759: Add help properties
KianRolf Nov 29, 2024
1126b60
Merge branch 'implement/759-UpgradeSettingsCommandlet' of https://git…
KianRolf Nov 29, 2024
f6277b4
Update ShellCommandlet.java
KianRolf Nov 29, 2024
a6fdcca
Update ShellCommandlet.java
KianRolf Nov 29, 2024
fa91325
Rename ide.properties to devon.properties
KianRolf Nov 29, 2024
c980055
#759: Test beginning
KianRolf Nov 29, 2024
587ebb9
Update CHANGELOG.adoc
leonrohne27 Nov 29, 2024
b919d35
#759: fixed documention link
leonrohne27 Nov 29, 2024
cd751e1
Merge branch 'implement/759-UpgradeSettingsCommandlet' of https://git…
leonrohne27 Nov 29, 2024
db2a4a7
#759: use getSettingsPath() for resolving settings directories
leonrohne27 Nov 29, 2024
d7f60da
#759: file_path to filePath
leonrohne27 Nov 29, 2024
6f3229e
#759: Changed method name
leonrohne27 Nov 29, 2024
afaa4f7
#759: changed checkForXmlNamespace() method
leonrohne27 Nov 29, 2024
3322aa2
Merge branch 'implement/759-UpgradeSettingsCommandlet' of https://git…
KianRolf Nov 29, 2024
589eb25
#759: Test for commandlet
KianRolf Nov 29, 2024
97cae94
#759: Javadoc
KianRolf Nov 29, 2024
1801808
#759: clean up
KianRolf Nov 29, 2024
694a7b8
#759: changed structure for XmlNamespace() method
leonrohne27 Nov 29, 2024
84ed5a4
Merge branch 'main' into implement/759-UpgradeSettingsCommandlet
jan-vcapgemini Dec 16, 2024
1383b7b
Merge branch 'main' into implement/759-UpgradeSettingsCommandlet
jan-vcapgemini Dec 18, 2024
b614c6d
#759: optimized parsing of custom tools
jan-vcapgemini Dec 18, 2024
6408d55
#759: added missing changes
jan-vcapgemini Dec 18, 2024
1902729
#759: fixed test
jan-vcapgemini Dec 18, 2024
3c85ec1
#759: rewritten implementation to upgrade variable expressions in wor…
hohwille Dec 19, 2024
7f2d622
#759: implemented requested changes
jan-vcapgemini Dec 20, 2024
c4f3aa5
#759: push changes of DirectoryMergerTest
hohwille Dec 20, 2024
9960940
#759: implemented requested changes
jan-vcapgemini Dec 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Release with new features and bugfixes:

* https://github.com/devonfw/IDEasy/issues/888[#888]: Removed gu update functionality (needs to be run manually for old versions now).
* https://github.com/devonfw/IDEasy/issues/885[#885]: Gcviewer starts in foreground fixed
* https://github.com/devonfw/IDEasy/issues/759[#759]: Create UpgradeSettingsCommandlet

The full list of changes for this release can be found in https://github.com/devonfw/IDEasy/milestone/17?closed=1[milestone 2024.12.002].

Expand Down
5 changes: 5 additions & 0 deletions cli/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@
<artifactId>jakarta.json-api</artifactId>
<version>2.1.3</version>
</dependency>
<dependency>
<groupId>com.googlecode.json-simple</groupId>
<artifactId>json-simple</artifactId>
<version>1.1.1</version>
</dependency>
Comment on lines +38 to +42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?
We already have JSONP (Jakarta Standard for parsing JSON) and Jackson (Mapping XML and JSON from/to Java objects).
Adding this library does not make any sense to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also if we add new libraries to our product we also have to add that to our license.

<dependency>
<groupId>org.eclipse.parsson</groupId>
<artifactId>parsson</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ public CommandletManagerImpl(IdeContext context) {
add(new RepositoryCommandlet(context));
add(new UninstallCommandlet(context));
add(new UpdateCommandlet(context));
add(new UpgradeSettingsCommandlet(context));
add(new CreateCommandlet(context));
add(new BuildCommandlet(context));
add(new InstallPluginCommandlet(context));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ public void run() {
return;
}

List<Path> propertiesFiles = this.context.getFileAccess().listChildren(repositories, path -> path.getFileName().toString().endsWith(".properties"));
List<Path> propertiesFiles = this.context.getFileAccess()
.listChildren(repositories, path -> path.getFileName().toString().endsWith(".properties"));

boolean forceMode = this.context.isForceMode();
for (Path propertiesFile : propertiesFiles) {
Expand Down
Loading
Loading