Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#347: Change copy method behavior to be consistent #359

Merged
merged 7 commits into from
May 28, 2024
Merged

#347: Change copy method behavior to be consistent #359

merged 7 commits into from
May 28, 2024

Conversation

ndemirca
Copy link
Contributor

Closes #347

@ndemirca ndemirca requested a review from hohwille May 27, 2024 08:52
@coveralls
Copy link
Collaborator

coveralls commented May 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9272330123

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 80 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.004%) to 59.623%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/io/FileCopyMode.java 1 76.0%
com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java 1 82.3%
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 9 77.0%
com/devonfw/tools/ide/io/FileAccessImpl.java 69 55.52%
Totals Coverage Status
Change from base Build 9272083400: -0.004%
Covered Lines: 4667
Relevant Lines: 7541
💛 - Coveralls

@jan-vcapgemini
devonfw#347: fixed copy
3382e54 
added copy recursively with folder name
fixed test workarounds
removed extra resolve directory workarounds
@ndemirca ndemirca closed this May 28, 2024
@ndemirca ndemirca reopened this May 28, 2024
@ndemirca ndemirca assigned jan-vcapgemini and unassigned ndemirca May 28, 2024
@jan-vcapgemini jan-vcapgemini changed the title fixed copy method within extractdmg #347: Change copy method behavior to be consistent May 28, 2024
hohwille
hohwille approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndemirca excellent. Thanks for your PR. 👍
I updated the comment explaining the magic at the top of the copy method.
Could you remove the out-commented code (see comments).
Then we can merge.

cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java Outdated Show resolved Hide resolved
@hohwille hohwille merged commit 1e650d7 into devonfw:main May 28, 2024
3 checks passed
@hohwille hohwille mentioned this pull request Jun 13, 2024
Closed
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@hohwille hohwille

@jan-vcapgemini jan-vcapgemini

Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change copy method behavior to be consistent
4 participants
@ndemirca @coveralls @hohwille @jan-vcapgemini