Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#345: Improve Jasypt ToolCommandlet #358

Merged
merged 9 commits into from
Jun 18, 2024
Merged

#345: Improve Jasypt ToolCommandlet #358

merged 9 commits into from
Jun 18, 2024

Conversation

mvomiero
Copy link
Contributor

Fixes: #345

@mvomiero mvomiero self-assigned this May 27, 2024
@mvomiero mvomiero added enhancement New feature or request jasypt Java encryption and decryption tool labels May 27, 2024
@coveralls
Copy link
Collaborator

coveralls commented May 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9552573289

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 60.063%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/jasypt/Jasypt.java 2 82.5%
Totals Coverage Status
Change from base Build 9552528477: 0.004%
Covered Lines: 4724
Relevant Lines: 7563
💛 - Coveralls

@mvomiero mvomiero added this to the release:2024.06.001 milestone May 27, 2024
hohwille
hohwille approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvomiero thanks for your PR and for improving the code and help messages. Very nice 👍
I left some comments with my findings for potential improvement.
Please have a look.
Otherwise ready for merge.

cli/src/main/java/com/devonfw/tools/ide/tool/jasypt/Jasypt.java Outdated Show resolved Hide resolved
cli/src/test/resources/ide-projects/jasypt/repository/java/java/default/bin/java Outdated Show resolved Hide resolved
@hohwille hohwille merged commit b0dbea3 into devonfw:main Jun 18, 2024
4 checks passed
@mvomiero mvomiero deleted the enhancement/345-improveJasypt branch June 19, 2024 10:22
@mvomiero mvomiero added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@mvomiero mvomiero

Labels
enhancement New feature or request jasypt Java encryption and decryption tool reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.06.001
Development

Successfully merging this pull request may close these issues.

Improve Jasypt ToolCommandlet
3 participants
@mvomiero @coveralls @hohwille