Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#316: fix Jasypt version #354

Merged
merged 8 commits into from
Jun 17, 2024
Merged

#316: fix Jasypt version #354

merged 8 commits into from
Jun 17, 2024

Conversation

mvomiero
Copy link
Contributor

Fixes: #316 by checking if the version is equals or greater then 1.9.3 before adding it to the urls with JasyptUrlUpdater

@mvomiero mvomiero added this to the release:2024.06.001 milestone May 24, 2024
@mvomiero mvomiero changed the title Bug/316 jasypt version improvement #316: fix Jasypt version May 24, 2024
@mvomiero mvomiero added bugfix jasypt Java encryption and decryption tool labels May 24, 2024
@mvomiero mvomiero self-assigned this May 27, 2024
hohwille
hohwille requested changes May 28, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvomiero Thanks for your PR. Functionally working fine but I would love to propose a better solution.
See my review comments...

cli/src/main/java/com/devonfw/tools/ide/tool/jasypt/JasyptUrlUpdater.java Outdated Show resolved Hide resolved
cli/pom.xml Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/jasypt/JasyptUrlUpdater.java Outdated Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Jun 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9552428823

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 60.081%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/url/updater/MavenBasedUrlUpdater.java 8 0.0%
com/devonfw/tools/ide/tool/jasypt/JasyptUrlUpdater.java 9 0.0%
Totals Coverage Status
Change from base Build 9552422909: -0.06%
Covered Lines: 4722
Relevant Lines: 7559
💛 - Coveralls

hohwille
hohwille approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvomiero thanks for your PR. Looks good to me 👍
I added a tiny suggestion for improvement that you could accept. However, ready for merge.

cli/src/main/java/com/devonfw/tools/ide/tool/jasypt/JasyptUrlUpdater.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/tool/jasypt/JasyptUrlUpdater.java Outdated Show resolved Hide resolved
hohwille
hohwille approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvomiero thanks for the improvements 👍
Will merge now.

@hohwille hohwille merged commit 3a0726e into devonfw:main Jun 17, 2024
3 checks passed
@mvomiero mvomiero deleted the bug/316-jasyptVersionImprovement branch June 19, 2024 10:22
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@mvomiero mvomiero

Labels
bugfix jasypt Java encryption and decryption tool reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.06.001
Development

Successfully merging this pull request may close these issues.

Jasypt encryption and decryption fails with versions other than 1.9.3
3 participants
@mvomiero @coveralls @hohwille