Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#344: add generic list support to Property #350

Closed
wants to merge 1 commit into from
Closed

#344: add generic list support to Property #350

wants to merge 1 commit into from

Conversation

jan-vcapgemini
Copy link
Contributor

Fixes: #344

Implements:

  • adjusted all methods to use getValue
  • adjusted getter and setters

@jan-vcapgemini
devonfw#344: changed generic V to List<V>
df467ea 
adjusted all methods to use getValue
adjusted getter and setters
@jan-vcapgemini jan-vcapgemini changed the title #344: changed generic V to List<V> #344: add generic list support to Property May 23, 2024
@jan-vcapgemini jan-vcapgemini self-assigned this May 23, 2024
@jan-vcapgemini jan-vcapgemini added the enhancement New feature or request label May 23, 2024
@jan-vcapgemini jan-vcapgemini added this to the release:2024.05.001 milestone May 23, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9205657420

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 77 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.475%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/property/StringProperty.java 1 83.33%
com/devonfw/tools/ide/property/CommandletProperty.java 1 81.82%
com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java 1 82.3%
com/devonfw/tools/ide/property/VersionProperty.java 1 70.0%
com/devonfw/tools/ide/property/EnumProperty.java 2 13.64%
com/devonfw/tools/ide/property/PathProperty.java 3 5.17%
com/devonfw/tools/ide/commandlet/Commandlet.java 10 64.37%
com/devonfw/tools/ide/cli/CliArgument.java 15 66.67%
com/devonfw/tools/ide/property/StringListProperty.java 17 30.61%
com/devonfw/tools/ide/property/Property.java 26 73.21%
Totals Coverage Status
Change from base Build 9176576832: -0.05%
Covered Lines: 4654
Relevant Lines: 7540
💛 - Coveralls

@hohwille
Copy link
Member

Duplicate of PR #355

@jan-vcapgemini
Copy link
Contributor Author

Can be closed.

@jan-vcapgemini jan-vcapgemini deleted the feature/344-add-generic-list-support-to-property branch November 4, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jan-vcapgemini jan-vcapgemini

Labels
enhancement New feature or request
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.05.001
Development

Successfully merging this pull request may close these issues.

Add generic list support on Property
3 participants
@jan-vcapgemini @coveralls @hohwille