#326: Improved UninstallCommandlet to uninstall multiple tools#334
#326: Improved UninstallCommandlet to uninstall multiple tools#334ndemirca wants to merge 8 commits intodevonfw:mainfrom
Conversation
Pull Request Test Coverage Report for Build 9173412922Details
💛 - Coveralls |
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@ndemirca thanks for your PR and the nice idea to support uninstalling multiple tools in one call. 👍
Please have a look at my review comments and see what you think.
IMHO the current approach is not really consistent. Most probably we have to rethink how to implement this properly:
- Would we create a
ToolListProperty? - Or would it be even smarter to change the general design of
Propertyto allow some cardinality so every property can take any number of elements and by default the maximum is 1 and the minimum is 0 if not required and 1 if required? The cardinality could then be specified as an additional constructor argument to allow multiple parameters makingStringListPropertypointless and removed (instead usingStringPropertywith any number of parameters).
|
|
||
| /** The tool to uninstall. */ | ||
| public final ToolProperty tool; | ||
| public class UninstallCommandlet extends LocalToolCommandlet { |
There was a problem hiding this comment.
Inheriting from LocalToolCommandlet says that Uninstall is a tool that can be installed.
You can now do ide install uninstall and it will try to find a tool uninstall in ide-urls.
Also auto-completion will now suggest uninstall.
IMHO it is wrong to extend from LocalToolCommandlet here.
| </dependency> | ||
| <dependency> | ||
| <groupId>net.bytebuddy</groupId> | ||
| <artifactId>byte-buddy</artifactId> |
There was a problem hiding this comment.
why do we need byte-buddy now and what does it have to do with this story?
| public static final Tag ENCRYPTION = create("encryption", CRYPTO); | ||
|
|
||
| /** {@link #Tag} for uninstall. */ | ||
| public static final Tag UNINSTALL = create("uninstall", ROOT, false, "remove"); |
There was a problem hiding this comment.
I also would question this tag. The idea of tags is to choose tools and plugins.
What else could/would be tagged with uninstall? Tagging xyz with xyz does not really add much value unless xyz is a category that groups multiple things beyond xyz.
3 participants
Closes: #326