#236: fixed Eclipse plugin installation #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added missing arguments applied code reformat
Pull Request Test Coverage Report for Build 9210493770Details
💛 - Coveralls |
hohwille
approved these changes
May 21, 2024
There was a problem hiding this comment.
@jan-vcapgemini thanks for your analysis of the problem and the fixing PR.
Looks good to me and ready for merge. Great work 👍
Probably runEclipse will still be used for lower-level checks where the additional arguments may partially get in the way but let use wait and see. If that ever happens, we can still create a new issue...
hohwille
reviewed
May 21, 2024
cli/src/main/java/com/devonfw/tools/ide/tool/eclipse/Eclipse.java
Outdated
Show resolved
Hide resolved
hohwille
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #236
Implements