-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#280: configure maven properly #305
#280: configure maven properly #305
Conversation
Pull Request Test Coverage Report for Build 9030688796Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your addition, finally we can use maven properly :)
I've added some small CR's and I'd suggest to add tests for these features in a new PR as this feature is quite important and needs to be merged asap.
cli/src/main/java/com/devonfw/tools/ide/context/IdeContext.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your adjustments. I've added some small suggestions, but think this can go into review now.
cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContextImpl.java
Outdated
Show resolved
Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContextImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jan-vcapgemini <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvomiero thank you for your PR. Nice work, looks good. 👍
However, I left some review comments for rework to make everything consistent.
Please have a look and rework the commented spots then we can merge.
…IDEasy into enhancement/280-configureMaven
Fixes: #280
There is a related PR to
ide-settings
that renames thedevon
folder toide
, as suggested by @hohwille .devonfw/ide-settings#45
Note: the configuration will properly work just if the settings are properly updated (or if locally the
devon
folder insettings
is manually renamed toide
)