#12: Implement ToolCommandlet for Android Studio#299
Merged
hohwille merged 37 commits intodevonfw:mainfrom Jul 12, 2024
Merged
Conversation
added Android Studio IdeToolCommandlet with first runIde implementation for Windows and Mac added symlink creation
Collaborator
Pull Request Test Coverage Report for Build 9893436712Details
💛 - Coveralls |
added parameterized installation test
added testAndroidStudioRun test removed postInstall added simulated studio64.exe
removed unnecessary JDK installation (already included in SDK) removed unnecessary readme files and folders added javadocs added studio64.exe to .gitattributes to be handled as text file
added test resources for MacOS run test added old bash script creation (WIP probably not needed at all)
changed FileCopyMode from default to overwrite tree
replaced faulty tool path with open command for MacOS removed postInstall method
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java
mvomiero
reviewed
Apr 29, 2024
Contributor
mvomiero
left a comment
mvomiero
left a comment
There was a problem hiding this comment.
Nice implementation for this commandlet! LGTM 👍
cli/src/main/java/com/devonfw/tools/ide/tool/androidstudio/AndroidStudio.java
Outdated
Show resolved
Hide resolved
changed runAndroidStudio method to private
replaced runIde with runTool removed runAndroidStudio method adjusted test
# Conflicts: # .gitattributes
Jonnathanjaquez
approved these changes
May 8, 2024
Jonnathanjaquez
approved these changes
May 8, 2024
Jonnathanjaquez
approved these changes
May 8, 2024
tobka777
assigned
hohwille and
jan-vcapgemini and unassigned
jan-vcapgemini and
mvomiero
# Conflicts: # cli/src/main/resources/nls/Ide.properties # cli/src/main/resources/nls/Ide_de.properties
…://github.com/jan-vcapgemini/IDEasy into feature/12-implement-androidstudio-commandlet
# Conflicts: # cli/src/main/resources/nls/Help.properties # cli/src/main/resources/nls/Help_de.properties
# Conflicts: # .gitattributes # cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
added idea64.exe to gitattributes
hohwille
approved these changes
Jul 12, 2024
Member
hohwille
left a comment
hohwille
left a comment
There was a problem hiding this comment.
@jan-vcapgemini thanks for implementing this PR and testing all the combinations. 👍
Just like the IntelliJ PR we have some things that need to be reworked (MacOS workaround still buggy and undesired workaround code in this commandlet, OS specific switches for binary name, etc.) but we will address all of it in #339 so we can merge this now.
jan-vcapgemini
deleted the
feature/12-implement-androidstudio-commandlet
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12
Implements: