#252: include documentation into release (#253)

devonfw · Mar 18, 2024 · 70ea7c4 · 70ea7c4
1 parent 128bf5c
commit 70ea7c4
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 8 deletions.
diff --git a/cli/pom.xml b/cli/pom.xml
@@ -152,17 +152,17 @@
                 <configuration>
                   <artifacts>
                     <artifact>
-                      <file>target/${project.artifactId}-linux-x64.tar.gz</file>
+                      <file>${project.build.directory}/${project.artifactId}-linux-x64.tar.gz</file>
                       <type>tar.gz</type>
                       <classifier>linux</classifier>
                     </artifact>
                     <artifact>
-                      <file>target/${project.artifactId}-windows-x64.tar.gz</file>
+                      <file>${project.build.directory}/${project.artifactId}-windows-x64.tar.gz</file>
                       <type>tar.gz</type>
                       <classifier>windows</classifier>
                     </artifact>
                     <artifact>
-                      <file>target/${project.artifactId}-mac-x64.tar.gz</file>
+                      <file>${project.build.directory}/${project.artifactId}-mac-x64.tar.gz</file>
                       <type>tar.gz</type>
                       <classifier>mac</classifier>
                     </artifact>
@@ -206,16 +206,42 @@
               <agent>
                 <enabled>true</enabled>
               </agent>
-              <imageName>
-                ${imageName}
-              </imageName>
+              <imageName>${imageName}</imageName>
               <buildArgs>
                 <arg>--enable-url-protocols=https</arg>
                 <arg>-H:IncludeResources="nls/.*"</arg>
                 <arg>--initialize-at-build-time=org.apache.commons.compress</arg>
               </buildArgs>
             </configuration>
           </plugin>
+          <plugin>
+            <!-- Include documentation into release -->
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-dependency-plugin</artifactId>
+            <executions>
+              <execution>
+                <id>copy-documentation</id>
+                <phase>prepare-package</phase>
+                <goals>
+                  <goal>copy</goal>
+                </goals>
+              </execution>
+            </executions>
+            <configuration>
+              <artifactItems>
+                <artifactItem>
+                  <groupId>${project.groupId}</groupId>
+                  <artifactId>ide-doc</artifactId>
+                  <version>${project.version}</version>
+                  <type>pdf</type>
+                  <destFileName>IDEasy-documentation.pdf</destFileName>
+                </artifactItem>
+              </artifactItems>
+              <outputDirectory>${project.build.directory}/package</outputDirectory>
+              <overWriteReleases>false</overWriteReleases>
+              <overWriteSnapshots>true</overWriteSnapshots>
+            </configuration>
+          </plugin>
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-assembly-plugin</artifactId>
@@ -230,7 +256,7 @@
                   <finalName>${releaseName}</finalName>
                   <appendAssemblyId>false</appendAssemblyId>
                   <descriptors>
-                    <descriptor>/src/main/assembly/exec.xml</descriptor>
+                    <descriptor>/src/main/assembly/release.xml</descriptor>
                   </descriptors>
                 </configuration>
               </execution>

diff --git a/cli/src/main/assembly/exec.xml → cli/src/main/assembly/release.xml b/cli/src/main/assembly/exec.xml → cli/src/main/assembly/release.xml
diff --git a/cli/src/main/java/com/devonfw/tools/ide/repo/CustomToolRepositoryImpl.java b/cli/src/main/java/com/devonfw/tools/ide/repo/CustomToolRepositoryImpl.java
@@ -164,7 +164,7 @@ public static CustomToolRepository of(IdeContext context) {
           String url = getString(jsonToolObject, "url", defaultUrl);
           boolean osAgnostic = getBoolean(jsonToolObject, "os-agnostic", Boolean.FALSE);
           boolean archAgnostic = getBoolean(jsonToolObject, "arch-agnostic", Boolean.TRUE);
-          if (defaultUrl.isEmpty()) {
+          if (url.isEmpty()) {
             throw new IllegalStateException("Missing 'url' property for tool '" + name + "'!");
           }
           // TODO