compiler: Improve CIRE's cost model #2476
Open
+114
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2476 +/- ##
==========================================
- Coverage 87.19% 77.93% -9.27%
==========================================
Files 238 238
Lines 45201 45257 +56
Branches 4012 4019 +7
==========================================
- Hits 39415 35273 -4142
- Misses 5104 9231 +4127
- Partials 682 753 +71 ☔ View full report in Codecov by Sentry. |
FabioLuporini
force-pushed
the
tweak-cire-cm
branch
from
dea7217
to
94c9260
Compare
mloubout
reviewed
Oct 31, 2024
| nfunctions1 = len({i.function for i in indexeds1}) | ||
| ntemps = 0 | ||
| for sa in i.schedule: | ||
| if len(sa.writeto) < grid.dim: |
There was a problem hiding this comment.
sa.writeto.itdims? that comparison seems odd
mloubout
reviewed
Oct 31, 2024
| @@ -2153,7 +2217,7 @@ def test_multiple_rotating_dims(self): | |||
| # to jit-compile `op1`. However, we also check numerical correctness | |||
| op1.apply(time_m=0, time_M=nt-2, dt=dt, u=u1, vx=vx1, vy=vy1) | |||
|
|
|||
| assert np.allclose(u.data, u1.data, rtol=1e-5) | |||
| assert np.allclose(u.data, u1.data, rtol=1e-3) | |||
FabioLuporini
force-pushed
the
tweak-cire-cm
branch
from
94c9260
to
31344be
Compare
There was a problem hiding this comment.
I would expect to see some change in counted flops in other tests?
There was a problem hiding this comment.
Is this indeed affecting only the new variant you added?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.