-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiler: Improve CIRE's cost model #2476
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2476 +/- ##
==========================================
- Coverage 87.19% 77.93% -9.27%
==========================================
Files 238 238
Lines 45201 45257 +56
Branches 4012 4019 +7
==========================================
- Hits 39415 35273 -4142
- Misses 5104 9231 +4127
- Partials 682 753 +71 ☔ View full report in Codecov by Sentry. |
dea7217
to
94c9260
Compare
nfunctions1 = len({i.function for i in indexeds1}) | ||
ntemps = 0 | ||
for sa in i.schedule: | ||
if len(sa.writeto) < grid.dim: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sa.writeto.itdims
? that comparison seems odd
@@ -2153,7 +2217,7 @@ def test_multiple_rotating_dims(self): | |||
# to jit-compile `op1`. However, we also check numerical correctness | |||
op1.apply(time_m=0, time_M=nt-2, dt=dt, u=u1, vx=vx1, vy=vy1) | |||
|
|||
assert np.allclose(u.data, u1.data, rtol=1e-5) | |||
assert np.allclose(u.data, u1.data, rtol=1e-3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What this much change?
94c9260
to
31344be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect to see some change in counted flops in other tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this indeed affecting only the new variant you added?
No description provided.