mpi: Add basic2 mode #2307
mpi: Add basic2 mode #2307
Conversation
georgebisbas
force-pushed
the
basic2mpi
branch
from
024e82b
to
b4e67e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2307 +/- ##
==========================================
+ Coverage 86.99% 87.01% +0.01%
==========================================
Files 239 239
Lines 44957 45090 +133
Branches 8390 8415 +25
==========================================
+ Hits 39112 39234 +122
- Misses 5113 5121 +8
- Partials 732 735 +3 ☔ View full report in Codecov by Sentry. |
georgebisbas
force-pushed
the
basic2mpi
branch
from
befd078
to
89387c8
Compare
georgebisbas
force-pushed
the
basic2mpi
branch
4 times, most recently
from
ff919e2
to
895cef3
Compare
georgebisbas
force-pushed
the
basic2mpi
branch
from
895cef3
to
51411cc
Compare
|
|
||
| return SendRecv('sendrecv%s' % key, iet, parameters, bufg, bufs) | ||
|
|
||
| def _call_sendrecv(self, name, *args, msg=None, haloid=None): |
There was a problem hiding this comment.
why do you need a haloid here ? never had to use it. What makes this mode require it?
There was a problem hiding this comment.
Similarly to the same method in OverlapHalo. Each call to sendrecv has its own message indexedpointer
| mapper[(d0, side, region)] = (sizes) | ||
|
|
||
| i = 0 | ||
| for d in f.dimensions: |
There was a problem hiding this comment.
why not :
for i, halo in enumerate(self.halos):
like we have in the other message types?
There was a problem hiding this comment.
I followed the basic style, which does not have yet a method to cleanup the redundant halos as in diag2 for example:
e.g.:
# Only retain the halos required by the Diag scheme
halos = sorted(i for i in hse.halos if isinstance(i.dim, tuple))
I tried this but did not manage to get it working nicely.
georgebisbas
force-pushed
the
basic2mpi
branch
from
51411cc
to
6a0ce49
Compare
georgebisbas
force-pushed
the
basic2mpi
branch
from
6a0ce49
to
7d206db
Compare
tests/test_mpi.py
Outdated
| @@ -801,7 +801,7 @@ def test_trivial_eq_2d(self): | |||
| assert np.all(f.data_ro_domain[0, :-1, -1:] == side) | |||
| assert np.all(f.data_ro_domain[0, -1:, :-1] == side) | |||
|
|
|||
| @pytest.mark.parallel(mode=[(8, 'basic'), (8, 'diag'), (8, 'overlap'), | |||
| @pytest.mark.parallel(mode=[(8, 'basic'), (8, 'basic2'), (8, 'diag'), (8, 'overlap'), | |||
There was a problem hiding this comment.
I would drop basic here and below... or overlap perhaps. These tests can be quite expensive
georgebisbas
force-pushed
the
basic2mpi
branch
4 times, most recently
from
5a5e826
to
c266e14
Compare
georgebisbas
force-pushed
the
basic2mpi
branch
2 times, most recently
from
e849e40
to
55b11d5
Compare
| @@ -1185,6 +1297,16 @@ def _as_number(self, v, args): | |||
| assert args is not None | |||
| return int(subs_op_args(v, args)) | |||
|
|
|||
| def _allocate_buffers(self, f, shape, entry): | |||
There was a problem hiding this comment.
This could use some whitespace to make it more readable
| if d in fixed: | ||
| continue | ||
|
|
||
| if (d, LEFT) in self.halos: |
There was a problem hiding this comment.
for side in (LEFT, RIGHT):
if (d, side) in self.halos:
entry = self.value[i]
i += 1
shape = mapper[(d, side, OWNED)]
self._allocate_buffers(f, shape, entry)
mpi: Drop redundant determinism
georgebisbas
force-pushed
the
basic2mpi
branch
from
58dbb96
to
dab37fd
Compare
Preallocated buffers using MPIMsg.
An MPIMsgEnriched version for send/recv, will follow