Added support for Extended Advertisements for Android #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong API on BluetoothAdapter is getting called. Changed it to the according API call getDefaultAdapter()
qdot
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Extended Advertisements from Bluetooth 5.0 on Android.
When creating the
ScanSettingsobject by default only Legacy Advertisements are reported to the ScanCallback. From API Level 26 (Oreo) the developer has the option to also include Extended Advertisements to the reported ScanResults.Furthermore it is fixing a build issue in the Peripheral.java file where the wrong API call to
BluetoothAdapteris getting called and I updated it here as well. If necessary I can also do this in a separate PR.