Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Windows 10 versions before 2004 #402

Closed
wants to merge 1 commit into from

Conversation

wuwbobo2021
Copy link

@wuwbobo2021 wuwbobo2021 commented Oct 20, 2024

Fixes for this issue: #364.

Thanks to @ChristianPavilonis for providing the clue. He had forked this project and deleted the line that causes the problem.

This fix tries to keep the functionality as is, merely ignoring the returned error if SetAllowExtendedAdvertisements() isn't available.

@qwandor qwandor changed the base branch from master to dev October 20, 2024 09:25
@qwandor qwandor requested a review from qdot October 20, 2024 09:25
@qdot
Copy link
Contributor

qdot commented Dec 21, 2024

I'd really rather this be a conditional on the OS version rather then just throwing out the error completely, especially because this is such an old version of Win10. Also this needs comments for why it's happening.

Copy link
Contributor

@qdot qdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this a conditional that parses OS version, because I want to throw an error whenever possible. Also, needs comments about why this is happening since it's done for a rare platform.

@wuwbobo2021
Copy link
Author

wuwbobo2021 commented Dec 22, 2024

I'm switching to bluest because the only maintainer of btleplug is a sex toy maker from "Nonpolynomial LLC". It's unlikely for me to use this crate anymore.

I has been annoyed by the huge horrible icon in https://crates.io/crates/buttplug, which I occasionally discovered before checking the meaning of "butt" in the dictionary. After that I decided to report that crate on crates.io, however the reporting web page doesn't seems to be responding (I make deal with the crates.io bug later).

If only the icon was made much smaller.

https://www.rust-lang.org/policies/code-of-conduct
https://github.com/stumpsyn/policies/blob/master/citizen_code_of_conduct.md (4. Unacceptable Behavior)

Off-topic: As a non-Christian from China, I was suprised to see the guy named "Christian" talking to you friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants