fix(macos): Break the corebluetooth loop when manager turned off #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtrKovalenko
force-pushed
the
fix/core-bluetooth-stuck-forevert
branch
2 times, most recently
from
6eab2c5 to
60d00ca
Compare
closes deviceplug#387 In Core Bluetooth when the device is not applicable for background bluetooth manager will create an event for state change. And then change the manager state to power off. Currently, it is not tracked at all which leads to the forever stuck unresolved issues while the connection to peripheral is still held. An additional problem I faced that there is no way to manually kill the event loop of the corebluetooth from outside so the `CoreBluetoothInternal::drop` is never called because it is always living in the stalled thread. In this change, I added an API to access the manager state and exited the event loop when if the manager turned off.
dmtrKovalenko
force-pushed
the
fix/core-bluetooth-stuck-forevert
branch
from
60d00ca to
a0635d7
Compare
qdot
approved these changes
Oct 5, 2024
|
Ok, well, should've merged this before the corebluetooth API change. Patch looks fine but I need to go back and see what the conflicts are and if this is still valid given the event loop changes made during the API change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #387
In Core Bluetooth when the device is locked or suspended and it is not applicable for background Bluetooth access the manager will create an event for state change and after will change the manager state to powerOff. Currently, it is not tracked at all which
leads to the forever stuck unresolved futures while the connection to peripheral is still held.
An additional problem I faced that there is no way to manually kill the
event loop of the corebluetooth from outside so the
CoreBluetoothInternal::dropis never called because it is alwaysliving in the stalled thread.
In this change, I added an API to access the manager state and exited
the event loop when if the manager turned off.